Date: Wed, 11 Jun 2003 15:41:24 -0600 From: "Justin T. Gibbs" <gibbs@scsiguy.com> To: Thomas Moestl <t.moestl@tu-bs.de>, John-Mark Gurney <gurney_j@resnet.uoregon.edu> Cc: freebsd-sparc64@freebsd.org Subject: Re: PCI bus numbering and orphaned devices Message-ID: <385060000.1055367683@caspian.scsiguy.com> In-Reply-To: <20030610112458.GA734@crow.dom2ip.de> References: <20030609165838.32044@hydrogen.funkthat.com> <20030610112458.GA734@crow.dom2ip.de>
next in thread | previous in thread | raw e-mail | index | archive | help
>> + *
>> + * If we don't hardware the bus down, pciconf gets confused.
>> */
>> if (sc->secbus != 0) {
>> - child = device_add_child(dev, "pci", -1);
>> + child = device_add_child(dev, "pci", sc->secbus);
>> if (child != NULL)
>> return (bus_generic_attach(dev));
>> } else
>
> This one looks good, please commit. The comment above is outdated, so
> it might be better to just remove it completely.
At least fix the typo in the comment if you aren't going to remove it.
--
Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?385060000.1055367683>