Date: Fri, 20 Apr 2001 05:28:29 +0900 From: "Akinori MUSHA" <knu@iDaemons.org> To: "Bruce A. Mah" <bmah@FreeBSD.org> Cc: Kris Kennaway <kris@obsecurity.org>, David O'Brien <obrien@FreeBSD.org>, Chris Faulhaber <jedgar@fxp.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/editors/vim6 Makefile distinfo pkg-plist Message-ID: <864rvkd47m.wl@archon.local.idaemons.org> In-Reply-To: <200104191955.f3JJtQV60074@bmah-freebsd-0.cisco.com> References: <200104111956.f3BJukl93003@freefall.freebsd.org> <20010419140501.A253@jive.44bsd.net> <8666g0d8ws.wl@archon.local.idaemons.org> <20010419122255.B29435@dragon.nuxi.com> <20010419123216.A53260@xor.obsecurity.org> <200104191955.f3JJtQV60074@bmah-freebsd-0.cisco.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At Thu, 19 Apr 2001 12:55:26 -0700,
Bruce A. Mah <bmah@FreeBSD.org> wrote:
> I suspect we might need to tweak the comparison algorithm a bit. And
> it's not entirely clear to me what it should be either, even though knu
> and I just finished reworking it.
D'oh, I've just found pkg_version's bug!! It thinks 1.0a is smaller
than 1.0!
I am sorry I didn't look into and check your modification over my code
carefully, but why did you modify the test?? Apparently the test I
originally wrote had been modified incorrectly and that made
pkg_version not conform to what the Handbook says.
Index: test-pkg_version.sh
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/version/test-pkg_version.sh,v
retrieving revision 1.1
diff -u -r1.1 test-pkg_version.sh
--- test-pkg_version.sh 2001/04/03 21:26:32 1.1
+++ test-pkg_version.sh 2001/04/19 19:34:55
@@ -61,8 +61,8 @@
test-pv 2.3p10 ">" 2.3p9 number/letter
test-pv 1.6.0 ">" 1.6.0.p3 number/letter
test-pv 1.0.b ">" 1.0.a3 number/letter
-test-pv 1.0a "<" 1.0 number/letter
-test-pv 5.0a "<" 5.0.b number/letter
+test-pv 1.0a ">" 1.0 number/letter
+test-pv 5.0a ">" 5.0.b number/letter
test-pv 1.5_1 ">" 1.5 portrevision
test-pv 1.5_2 ">" 1.5_1 portrevision
Unfortunately, I couldn't find an easy hotfix against the stock
CompareNumbers() routine, as it no longer takes account of various
sequences and combinations of numbers and alphabets in a version
component.
I'd suggest you put my code back and roll the flawless version for
4.3-RELEASE, then hack it your way carefully again later.
Regards,
--
/
/__ __ Akinori.org / MUSHA.org
/ ) ) ) ) / FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp
"Freeze this moment a little bit longer, make each impression
a little bit stronger.. Experience slips away -- Time stand still"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864rvkd47m.wl>