Date: Mon, 06 Oct 2025 03:27:29 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Robert Clausecker <fuz@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: f95a776840b0 - main - benchmarks/vkoverhead: exorcise -Werror and unbreak on armv7 Message-ID: <4isc-es5a-wny@FreeBSD.org> In-Reply-To: <202510051345.595Djeo7032285@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Robert Clausecker <fuz@FreeBSD.org> writes: > The branch main has been updated by fuz: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=f95a776840b0d53d446a8f219ed6ed5a7b135029 > > commit f95a776840b0d53d446a8f219ed6ed5a7b135029 > Author: Robert Clausecker <fuz@FreeBSD.org> > AuthorDate: 2023-02-27 23:16:02 +0000 > Commit: Robert Clausecker <fuz@FreeBSD.org> > CommitDate: 2025-10-05 13:44:07 +0000 > > benchmarks/vkoverhead: exorcise -Werror and unbreak on armv7 > > This fixes the build on armv7, avoiding a bogus int conversion > warning. While we are at it, turn static REINPLACE_CMD usage > into patch file as per policy. > > Approved by: portmgr (build fix blanket) > MFH: 2025Q4 Did you test runtime? The code seems to assume VK_USE_64_BIT_PTR_DEFINES. For example, in i386 jail on amd64 host with drm-66-kmod (Intel GPU) vkoverhead results are bogus. Other Vulkan apps work fine, so bugs in drivers are unlikely. If you didn't test runtime, please, revert the change. It doesn't even build on i386 without a follow-up fix (see below). I also don't like how you've mixed style change that outright removed rationale (inline comment) despite Git making it easy to split changes into separate commits. --8<---------------cut here---------------start------------->8--- diff --git a/benchmarks/vkoverhead/Makefile b/benchmarks/vkoverhead/Makefile index 1aa0f9f98c95..df419048e432 100644 --- a/benchmarks/vkoverhead/Makefile +++ b/benchmarks/vkoverhead/Makefile @@ -4,6 +4,7 @@ DISTVERSION= 1.3 CATEGORIES= benchmarks PATCH_SITES= https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/ +PATCHFILES+= 70205fe77b17.patch:-p1 # https://github.com/zmike/vkoverhead/pull/12 PATCHFILES+= 62c8ad1a795f.patch:-p1 # https://github.com/zmike/vkoverhead/pull/12 MAINTAINER= jbeich@FreeBSD.org diff --git a/benchmarks/vkoverhead/distinfo b/benchmarks/vkoverhead/distinfo index da8174119c62..83ec58daf599 100644 --- a/benchmarks/vkoverhead/distinfo +++ b/benchmarks/vkoverhead/distinfo @@ -1,5 +1,7 @@ TIMESTAMP = 1739290615 SHA256 (zmike-vkoverhead-v1.3_GH0.tar.gz) = f7f13a91a09f29b7b63a4963c7bd4c01520cc0db9daf66912ae8e2f16dcdb377 SIZE (zmike-vkoverhead-v1.3_GH0.tar.gz) = 1055139 +SHA256 (70205fe77b17.patch) = 89dec85516230cd5af5ac8a450499ba58aa5d48b031acc7710850bbcb0839c23 +SIZE (70205fe77b17.patch) = 607 SHA256 (62c8ad1a795f.patch) = 7ca952381d658bb73eb8ab9fcc0bcff4d58aa37e3f6583a7fd46eec9ca7db8d6 SIZE (62c8ad1a795f.patch) = 648 --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- $ vkoverhead | Device Name | Driver Name | Driver Info | | ---------------------------------- | ----------------------------- | ----------- | | Intel(R) HD Graphics 530 (SKL GT2) | Intel open-source Mesa driver | Mesa 24.1.7 | | # | Draw Tests | 1000op/s | % relative to 'draw' | | --: | --------------------------------------------------- | -------: | -----: | | 0 | draw | 0 | 100.0% | | 1 | draw_multi | 0 | 50000.0% | | 2 | draw_vertex | 0 | 100.0% | | 3 | draw_multi_vertex | 0 | 50000.0% | | 4 | draw_index_change | 0 | 100.0% | | 5 | draw_index_offset_change | 0 | 100.0% | | 6 | draw_rp_begin_end | 0 | 100.0% | | 7 | draw_rp_begin_end_dynrender | 0 | 100.0% | | 8 | draw_rp_begin_end_dontcare | 0 | 100.0% | | 9 | draw_rp_begin_end_dontcare_dynrender | 0 | 100.0% | | 10 | draw_multirt | 0 | 100.0% | | 11 | draw_multirt_dynrender | 0 | 100.0% | | 12 | draw_multirt_begin_end | 0 | 100.0% | | 13 | draw_multirt_begin_end_dynrender | 0 | 100.0% | | 14 | draw_multirt_begin_end_dontcare | 0 | 100.0% | | 15 | draw_multirt_begin_end_dontcare_dynrender | 0 | 100.0% | | 16 | draw_vbo_change | 0 | 100.0% | | 17 | draw_vbo_change_dynamic | 0 | 100.0% | | 18 | draw_1vattrib_change | 0 | 100.0% | | 19 | draw_16vattrib | 0 | 100.0% | | 20 | draw_16vattrib_16vbo_change | 0 | 100.0% | | 21 | draw_16vattrib_change | 0 | 100.0% | | 22 | draw_16vattrib_change_dynamic | 0 | 100.0% | | 23 | draw_16vattrib_change_gpl | 0 | 100.0% | | 24 | draw_16vattrib_change_gpl_hashncache | 0 | 100.0% | | 25 | draw_1ubo_change | 0 | 100.0% | | 26 | draw_12ubo_change | 0 | 100.0% | | 27 | draw_1combined_sampler_change | 0 | 100.0% | | 28 | draw_16combined_sampler_change | 0 | 100.0% | | 29 | draw_1texelbuffer_change | 0 | 100.0% | | 30 | draw_16texelbuffer_change | 0 | 100.0% | | 31 | draw_1ssbo_change | 0 | 100.0% | | 32 | draw_8ssbo_change | 0 | 100.0% | | 33 | draw_1image_change | 0 | 100.0% | | 34 | draw_16image_change | 0 | 100.0% | | 35 | draw_1imagebuffer_change | 0 | 100.0% | | 36 | draw_16imagebuffer_change | 0 | 100.0% | | 37 | draw_ubo_db_change | 0 | 100.0% | | 38 | draw_ssbo_db_change | 0 | 100.0% | | 39 | draw_combined_sampler_db_change | 0 | 100.0% | | 40 | draw_image_db_change | 0 | 100.0% | | # | Submit Tests | op/s | % relative to 'submit_noop | | --: | --------------------------------------------------- | -------: | -----: | | 41 | submit_noop | 0 | 100.0% | | 42 | submit_50noop | 0 | 100.0% | | 43 | submit_1cmdbuf | 0 | 100.0% | | 44 | submit_50cmdbuf | 0 | 100.0% | | 45 | submit_50cmdbuf_50submit | 0 | 100.0% | | # | Descriptor Tests | 1000op/s | % relative to 'descriptor_noop' | | --: | --------------------------------------------------- | -------: | -----: | | 46 | descriptor_noop | 0 | 100.0% | | 47 | descriptor_1ubo | 0 | 100.0% | | 48 | descriptor_template_1ubo | 0 | 100.0% | | 49 | descriptor_template_1ubo_push | 0 | 100.0% | | 50 | descriptor_12ubo | 0 | 100.0% | | 51 | descriptor_template_12ubo | 0 | 100.0% | | 52 | descriptor_template_12ubo_push | 0 | 100.0% | | 53 | descriptor_1combined_sampler | 0 | 100.0% | | 54 | descriptor_template_1combined_sampler | 0 | 100.0% | | 55 | descriptor_template_1combined_sampler_push | 0 | 100.0% | | 56 | descriptor_16combined_sampler | 0 | 100.0% | | 57 | descriptor_template_16combined_sampler | 0 | 100.0% | | 58 | descriptor_template_16combined_sampler_push | 0 | 100.0% | | 59 | descriptor_1sampled_image | 0 | 100.0% | | 60 | descriptor_template_1sampled_image | 0 | 100.0% | | 61 | descriptor_template_1sampled_image_push | 0 | 100.0% | | 62 | descriptor_16sampled_image | 0 | 100.0% | | 63 | descriptor_template_16sampled_image | 0 | 100.0% | | 64 | descriptor_template_16sampled_image_push | 0 | 100.0% | | 65 | descriptor_1texelbuffer | 0 | 100.0% | | 66 | descriptor_template_1texelbuffer | 0 | 100.0% | | 67 | descriptor_template_1texelbuffer_push | 0 | 100.0% | | 68 | descriptor_16texelbuffer | 0 | 100.0% | | 69 | descriptor_template_16texelbuffer | 0 | 100.0% | | 70 | descriptor_template_16texelbuffer_push | 0 | 100.0% | | 71 | descriptor_1ssbo | 0 | 100.0% | | 72 | descriptor_template_1ssbo | 0 | 100.0% | | 73 | descriptor_template_1ssbo_push | 0 | 100.0% | | 74 | descriptor_8ssbo | 0 | 100.0% | | 75 | descriptor_template_8ssbo | 0 | 100.0% | | 76 | descriptor_template_8ssbo_push | 0 | 100.0% | | 77 | descriptor_1image | 0 | 100.0% | | 78 | descriptor_template_1image | 0 | 100.0% | | 79 | descriptor_template_1image_push | 0 | 100.0% | | 80 | descriptor_16image | 0 | 100.0% | | 81 | descriptor_template_16image | 0 | 100.0% | | 82 | descriptor_template_16image_push | 0 | 100.0% | | 83 | descriptor_1imagebuffer | 0 | 100.0% | | 84 | descriptor_template_1imagebuffer | 0 | 100.0% | | 85 | descriptor_template_1imagebuffer_push | 0 | 100.0% | | 86 | descriptor_16imagebuffer | 0 | 100.0% | | 87 | descriptor_template_16imagebuffer | 0 | 100.0% | | 88 | descriptor_template_16imagebuffer_push | 0 | 100.0% | | 89 | descriptor_buffer_offset_ubo | 0 | 100.0% | | 90 | descriptor_buffer_offset_combined_sampler | 0 | 100.0% | | 91 | descriptor_buffer_offset_sampled_image | 0 | 100.0% | | 92 | descriptor_buffer_offset_texelbuffer | 0 | 100.0% | | 93 | descriptor_buffer_offset_ssbo | 0 | 100.0% | | 94 | descriptor_buffer_offset_image | 0 | 100.0% | | 95 | descriptor_buffer_offset_imagebuffer | 0 | 100.0% | | 96 | descriptor_copy_1ubo | 0 | 100.0% | | 97 | descriptor_copy_12ubo | 0 | 100.0% | | 98 | descriptor_copy_1combined_sampler | 0 | 100.0% | | 99 | descriptor_copy_16combined_sampler | 0 | 100.0% | | 100 | descriptor_copy_1sampled_image | 0 | 100.0% | | 101 | descriptor_copy_16sampled_image | 0 | 100.0% | | 102 | descriptor_copy_1texelbuffer | 0 | 100.0% | | 103 | descriptor_copy_16texelbuffer | 0 | 100.0% | | 104 | descriptor_copy_1ssbo | 0 | 100.0% | | 105 | descriptor_copy_8ssbo | 0 | 100.0% | | 106 | descriptor_copy_1image | 0 | 100.0% | | 107 | descriptor_copy_16image | 0 | 100.0% | | 108 | descriptor_copy_1imagebuffer | 0 | 100.0% | | 109 | descriptor_copy_16imagebuffer | 0 | 100.0% | | 110 | descriptor_copy_mutable_1ubo | 0 | 100.0% | | 111 | descriptor_copy_mutable_12ubo | 0 | 100.0% | | 112 | descriptor_copy_mutable_1combined_sampler | 0 | 100.0% | | 113 | descriptor_copy_mutable_16combined_sampler | 0 | 100.0% | | 114 | descriptor_copy_mutable_1sampled_image | 0 | 100.0% | | 115 | descriptor_copy_mutable_16sampled_image | 0 | 100.0% | | 116 | descriptor_copy_mutable_1texelbuffer | 0 | 100.0% | | 117 | descriptor_copy_mutable_16texelbuffer | 0 | 100.0% | | 118 | descriptor_copy_mutable_1ssbo | 0 | 100.0% | | 119 | descriptor_copy_mutable_8ssbo | 0 | 100.0% | | 120 | descriptor_copy_mutable_1image | 0 | 100.0% | | 121 | descriptor_copy_mutable_16image | 0 | 100.0% | | 122 | descriptor_copy_mutable_1imagebuffer | 0 | 100.0% | | 123 | descriptor_copy_mutable_16imagebuffer | 0 | 100.0% | | # | Misc Tests | 1000op/s (besides zerovram) | % (ignore) | | --: | --------------------------------------------------- | -------: | -----: | | 124 | misc_resolve | 0 | 100.0% | | 125 | misc_resolve_4region | 0 | 100.0% | | 126 | misc_resolve_4region_mismatched | 0 | 100.0% | | 127 | misc_resolve_mutable | 0 | 100.0% | | 128 | misc_resolve_mutable_4region | 0 | 100.0% | | 129 | misc_resolve_mutable_4region_mismatched | 0 | 100.0% | | 130 | misc_copy | 0 | 100.0% | | 131 | misc_copy_4region | 0 | 100.0% | | 132 | misc_copy_4region_mismatched | 0 | 100.0% | | 133 | misc_copy_mutable | 0 | 100.0% | | 134 | misc_copy_mutable_4region | 0 | 100.0% | | 135 | misc_copy_mutable_4region_mismatched | 0 | 100.0% | | 136 | misc_compile_fastlink_depthonly | 0 | 100.0% | | 137 | misc_compile_fastlink_slow | 0 | 100.0% | | !!! | zerovram tests must be used with -fixed | !!!!!!!! | !!!!!! | | 138 | misc_zerovram | Unsupported | smh Intel | | !!! | zerovram tests must be used with -fixed | !!!!!!!! | !!!!!! | | 139 | misc_zerovram_manual | Unsupported | smh Intel | | # | Host Image Copy Tests | op/s | % relative to 'fmt_upload_memcpy' | | --: | --------------------------------------------------- | -------: | -----: | | 140 | hic_upload_memcpy_r8 | Unsupported | smh Intel | | 140 | hic_upload_memcpy_r8 | Unsupported | smh Intel | | 141 | hic_upload_tiled_r8 | Unsupported | smh Intel | | 142 | hic_upload_memcpy_uncached_r8 | Unsupported | smh Intel | | 143 | hic_upload_tiled_uncached_r8 | Unsupported | smh Intel | | 144 | hic_download_memcpy_r8 | Unsupported | smh Intel | | 145 | hic_download_tiled_r8 | Unsupported | smh Intel | | 146 | hic_download_memcpy_uncached_r8 | Unsupported | smh Intel | | 147 | hic_download_tiled_uncached_r8 | Unsupported | smh Intel | | 148 | hic_upload_memcpy_r16 | Unsupported | smh Intel | | 148 | hic_upload_memcpy_r16 | Unsupported | smh Intel | | 149 | hic_upload_tiled_r16 | Unsupported | smh Intel | | 150 | hic_upload_memcpy_uncached_r16 | Unsupported | smh Intel | | 151 | hic_upload_tiled_uncached_r16 | Unsupported | smh Intel | | 152 | hic_download_memcpy_r16 | Unsupported | smh Intel | | 153 | hic_download_tiled_r16 | Unsupported | smh Intel | | 154 | hic_download_memcpy_uncached_r16 | Unsupported | smh Intel | | 155 | hic_download_tiled_uncached_r16 | Unsupported | smh Intel | | 156 | hic_upload_memcpy_r32 | Unsupported | smh Intel | | 156 | hic_upload_memcpy_r32 | Unsupported | smh Intel | | 157 | hic_upload_tiled_r32 | Unsupported | smh Intel | | 158 | hic_upload_memcpy_uncached_r32 | Unsupported | smh Intel | | 159 | hic_upload_tiled_uncached_r32 | Unsupported | smh Intel | | 160 | hic_download_memcpy_r32 | Unsupported | smh Intel | | 161 | hic_download_tiled_r32 | Unsupported | smh Intel | | 162 | hic_download_memcpy_uncached_r32 | Unsupported | smh Intel | | 163 | hic_download_tiled_uncached_r32 | Unsupported | smh Intel | | 164 | hic_upload_memcpy_r32g32 | Unsupported | smh Intel | | 164 | hic_upload_memcpy_r32g32 | Unsupported | smh Intel | | 165 | hic_upload_tiled_r32g32 | Unsupported | smh Intel | | 166 | hic_upload_memcpy_uncached_r32g32 | Unsupported | smh Intel | | 167 | hic_upload_tiled_uncached_r32g32 | Unsupported | smh Intel | | 168 | hic_download_memcpy_r32g32 | Unsupported | smh Intel | | 169 | hic_download_tiled_r32g32 | Unsupported | smh Intel | | 170 | hic_download_memcpy_uncached_r32g32 | Unsupported | smh Intel | | 171 | hic_download_tiled_uncached_r32g32 | Unsupported | smh Intel | | 172 | hic_upload_memcpy_r32g32b32a32 | Unsupported | smh Intel | | 172 | hic_upload_memcpy_r32g32b32a32 | Unsupported | smh Intel | | 173 | hic_upload_tiled_r32g32b32a32 | Unsupported | smh Intel | | 174 | hic_upload_memcpy_uncached_r32g32b32a32 | Unsupported | smh Intel | | 175 | hic_upload_tiled_uncached_r32g32b32a32 | Unsupported | smh Intel | | 176 | hic_download_memcpy_r32g32b32a32 | Unsupported | smh Intel | | 177 | hic_download_tiled_r32g32b32a32 | Unsupported | smh Intel | | 178 | hic_download_memcpy_uncached_r32g32b32a32 | Unsupported | smh Intel | | 179 | hic_download_tiled_uncached_r32g32b32a32 | Unsupported | smh Intel | --8<---------------cut here---------------end--------------->8---home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4isc-es5a-wny>