Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 May 2011 21:25:14 +0000 (UTC)
From:      Navdeep Parhar <np@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r221859 - stable/8/sys/dev/cxgbe
Message-ID:  <201105132125.p4DLPEhP082917@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: np
Date: Fri May 13 21:25:14 2011
New Revision: 221859
URL: http://svn.freebsd.org/changeset/base/221859

Log:
  MFC r221464:
  Always re-arm an iq's interrupt before leaving the handler.

Modified:
  stable/8/sys/dev/cxgbe/t4_sge.c

Modified: stable/8/sys/dev/cxgbe/t4_sge.c
==============================================================================
--- stable/8/sys/dev/cxgbe/t4_sge.c	Fri May 13 20:58:48 2011	(r221858)
+++ stable/8/sys/dev/cxgbe/t4_sge.c	Fri May 13 21:25:14 2011	(r221859)
@@ -499,11 +499,8 @@ t4_intr_fwd(void *arg)
 		iq_next(iq);
 	}
 
-	if (ndesc_total > 0) {
-		t4_write_reg(sc, MYPF_REG(A_SGE_PF_GTS),
-		    V_CIDXINC(ndesc_pending) | V_INGRESSQID((u32)iq->cntxt_id) |
-		    V_SEINTARM(iq->intr_params));
-	}
+	t4_write_reg(sc, MYPF_REG(A_SGE_PF_GTS), V_CIDXINC(ndesc_pending) |
+	    V_INGRESSQID((u32)iq->cntxt_id) | V_SEINTARM(iq->intr_params));
 
 	atomic_cmpset_32(&iq->state, IQS_BUSY, IQS_IDLE);
 }
@@ -601,11 +598,8 @@ t4_evt_rx(void *arg)
 		iq_next(iq);
 	}
 
-	if (ndesc_total > 0) {
-		t4_write_reg(sc, MYPF_REG(A_SGE_PF_GTS),
-		    V_CIDXINC(ndesc_pending) | V_INGRESSQID(iq->cntxt_id) |
-		    V_SEINTARM(iq->intr_params));
-	}
+	t4_write_reg(sc, MYPF_REG(A_SGE_PF_GTS), V_CIDXINC(ndesc_pending) |
+	    V_INGRESSQID(iq->cntxt_id) | V_SEINTARM(iq->intr_params));
 }
 
 void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105132125.p4DLPEhP082917>