Date: Fri, 17 Jun 2011 08:41:34 +0800 From: wen heping <wenheping@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Wen Heping <wen@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/sysutils/tmux Makefile Message-ID: <BANLkTik%2BjDPfp2UrCHZ8A2WyuZztDj0cZw@mail.gmail.com> In-Reply-To: <20110616164733.GA40181@FreeBSD.org> References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/6/17 Alexey Dokuchaev <danfe@freebsd.org>: > On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: >> wen 2011-06-16 08:42:28 UTC >> >> Modified files: >> sysutils/tmux Makefile >> Log: >> - Fix build when CFLAGS is set in /etc/make.conf > > Hmm, default CPPFLAGS is empty. Judging just from the diff, instead of > introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which is > bogus in the first place: -I is preprocessor flag) should be enough (no If CPPFLAGS defined in /etc/make.conf, the build fails too. wen > MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in this > case as well). I am missing something obvious here? > > ./danfe >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTik%2BjDPfp2UrCHZ8A2WyuZztDj0cZw>