Date: Wed, 26 Apr 2017 16:15:05 +0000 From: rgrimes <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D10485: Replace dhcp option 150 by 66 Message-ID: <1ca37c14090e62811eb89ba454fe0cb2@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-rdfe23ryefhflnjblbcr-req@FreeBSD.org> References: <differential-rev-PHID-DREV-rdfe23ryefhflnjblbcr-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
rgrimes added a comment. In https://reviews.freebsd.org/D10485#217709, @kczekirda wrote: > @rgrimes > RFC1048 is here, because 1048 is a part of names of functions or variables in bootp.c, I think we should rename them. I updated the description of revision with part about dotted quad. Probably we have no better way to do that. For now it might be best to leave them with old names and just try to remember when writing code it is a bad idea to use rfc numbers in variables names as that is something very likely to change over time as it has here. Maybe sprinkle a few comments next to them at some point in time saying rfc1048 has been updated. REVISION DETAIL https://reviews.freebsd.org/D10485 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp Cc: rgrimes, garga, ler, asomers
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1ca37c14090e62811eb89ba454fe0cb2>