Date: Wed, 29 Jul 2015 12:48:15 -0400 From: "George Neville-Neil" <gnn@neville-neil.com> To: "Gleb Smirnoff" <glebius@FreeBSD.org> Cc: "Ermal =?utf-8?q?Lu=C3=A7i?=" <eri@freebsd.org>, "Olivier =?utf-8?q?Cochard-Labb=C3=A9?=" <olivier@cochard.me>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285051 - head/sys/netinet Message-ID: <B341CBB9-DF4A-4455-B086-9446BA059198@neville-neil.com> In-Reply-To: <20150729150544.GM97401@FreeBSD.org> References: <201507021810.t62IAgCc003272@repo.freebsd.org> <20150728124220.GW72729@FreeBSD.org> <CAPBZQG3owDM4y4noEa9S044MPuw89QZnkG6Ne7y94iBERp37Pg@mail.gmail.com> <20150729150544.GM97401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 Jul 2015, at 11:05, Gleb Smirnoff wrote:
> Ermal,
>
> On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Luçi wrote:
> E> > E> @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m, int srcrt)
> E> > E> */
> E> > E> if (!srcrt && ia == NULL) {
> E> > E> icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_HOST, 0,
> 0);
> E> > E> + RO_RTFREE(&ro);
> E> > E> return;
> E> > E> }
> E> >
> E> > Here the ifa reference is leaked upon return.
> E> >
> E> >
> E> Gleb,
> E>
> E> the improvement on the ifa_ref not needed is something to look at
> but the
> E> ifa_ref here is not lost since ia == NULL, no?
> E> Maybe i am missing something else.
>
> Sure you are right. Mea culpa.
>
> E> Also can we put this on a review?
>
> It is possible. Let's just wait for Olivier to return and ask him to
> do a benchmark :)
>
Olivier isnt' the only one that can do a benchmark. I can chuck this up
in the
Sentex lab, that's what it's for. Give me a brief outline and I'll code
something
up in Conductor.
Best,
George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B341CBB9-DF4A-4455-B086-9446BA059198>