Date: Wed, 31 Dec 2014 21:35:23 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, Warner Losh <imp@FreeBSD.org>, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Dimitry Andric <dim@FreeBSD.org> Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf Message-ID: <E857293A-307A-4C3C-9385-CEAA29C146E1@gmail.com> In-Reply-To: <4F74425F-68B9-4BA2-A962-6C1AA77B4C75@gmail.com> References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> <E1FA7448-844B-4454-8C2C-5592198D0570@gmail.com> <FC1DD917-D28C-44B8-9BE8-45A57F4A9EA6@bsdimp.com> <E041E7F2-CC45-4D7B-912F-E5F86772E44A@gmail.com> <A002DA3A-0047-4F83-8896-25AEEBF489A3@gmail.com> <4F74425F-68B9-4BA2-A962-6C1AA77B4C75@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Dec 31, 2014, at 21:20, Garrett Cooper <yaneurabeya@gmail.com> wrote:
> On Dec 31, 2014, at 21:12, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>
>> On Dec 31, 2014, at 20:44, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>>
>>> On Dec 31, 2014, at 20:25, Warner Losh <imp@bsdimp.com> wrote:
>>
>> …
>>
>>>> This change is wrong. bsd.sys.mk was eliminated on purpose, dammit.
>>>
>>> Sorry. Should have asked first. Now the build is broken on all architectures :/. What next?
>>
>> Also, that code has been in there for over a decade. It seems a bit dangerous to remove it without at least a ports -exp or make tinderbox run…
>
> Hmmm… would it make sense to disable clang warnings from within bsd.sys.mk, like we do with sparc64?
> Thanks!
>
> 117 .if ${MACHINE_CPUARCH} == "sparc64"
> 118 # Don't emit .cfi directives, since we must use GNU as on sparc64, for now.
> 119 CFLAGS.clang+= -fno-dwarf2-cfi-asm
> 120 .endif # SPARC64
Or just disable -Werror...?
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEbBAEBCgAGBQJUpNybAAoJEMZr5QU6S73e9KQH+LvbJHrn5Tlw4aeyiBpnGrcP
kROe5a0xSJbrFIoguz/7mN6Pab41Z2Q0aonHROshPnImFmNV1ZJWo1ATWJxF+/0N
nBF3TGRKN+9p83iUmRv+ouyDbnqu+cyz8JtfmbyzmeNJPDOIIC/eS1iqcz8ViPZO
qARjq4QZXza4j+2tzeoo6qnWg6Wlzz4ewGcC916MgchhMvWkThXP2LtqYbSxNSW3
qaLLbV/yXcBnovz7bHvw+1UMIRvk7EO71VVIWLZaj9qyt45AxEJrZLkNhA4p1K9m
eEb+akJgBdc8Xa0z8/peWAMrA5G2p2oQmY9/a+ZcCXmK5yDTStuDZ+oWknxeQA==
=JJEj
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E857293A-307A-4C3C-9385-CEAA29C146E1>