Date: Thu, 10 May 2012 20:28:33 +0000 (UTC) From: Sergey Kandaurov <pluknet@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r235241 - head/sys/fs/ext2fs Message-ID: <201205102028.q4AKSXLk050443@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: pluknet Date: Thu May 10 20:28:33 2012 New Revision: 235241 URL: http://svn.freebsd.org/changeset/base/235241 Log: Fix mount interlock oversights from the previous change in r234386. Reported by: dougb Submitted by: Mateusz Guzik <mjguzik at gmail com> Reviewed by: Kirk McKusick Tested by: pho Modified: head/sys/fs/ext2fs/ext2_vfsops.c Modified: head/sys/fs/ext2fs/ext2_vfsops.c ============================================================================== --- head/sys/fs/ext2fs/ext2_vfsops.c Thu May 10 20:13:24 2012 (r235240) +++ head/sys/fs/ext2fs/ext2_vfsops.c Thu May 10 20:28:33 2012 (r235241) @@ -830,7 +830,6 @@ ext2_sync(struct mount *mp, int waitfor) /* * Write back each (modified) inode. */ - MNT_ILOCK(mp); loop: MNT_VNODE_FOREACH_ALL(vp, mp, mvp) { if (vp->v_type == VNON) { @@ -847,7 +846,6 @@ loop: } error = vget(vp, LK_EXCLUSIVE | LK_NOWAIT | LK_INTERLOCK, td); if (error) { - MNT_ILOCK(mp); if (error == ENOENT) { MNT_VNODE_FOREACH_ALL_ABORT(mp, mvp); goto loop;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205102028.q4AKSXLk050443>