Date: Wed, 27 Jan 1999 18:29:33 -0800 (PST) From: Archie Cobbs <archie@whistle.com> To: wollman@khavrinen.lcs.mit.edu (Garrett Wollman) Cc: current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h Message-ID: <199901280229.SAA20207@bubba.whistle.com> In-Reply-To: <199901280222.VAA14212@khavrinen.lcs.mit.edu> from Garrett Wollman at "Jan 27, 99 09:22:43 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Garrett Wollman writes:
> > Please do go ahead and update it.. the experts agree!
>
> I haven't seen any experts involved in this discussion yet. It's
> probably after bedtime down there in oz.
It was discussed before a couple of weeks ago, and I didn't hear
anybody on the other side. I could be mistaken though.
Anyway, if we're going to -Wall'ify the kernel (as we should)
then we need to update sytle(9) to reflect that.
In fact, style(9) should say:
If at all possible, your code should compile without warnings
when the gcc -Wall flag is given.
As it stands now (and I QUOTE!) it says:
Don't use parentheses unless they're required for precedence, or
the statement is really confusing without them.
a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1;
That's ridiculous!
If you're telling me that line is not 'really confusing' then..
hell, I don't know what. I guess I just strongly disagree.
-Archie
___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280229.SAA20207>