Date: Thu, 4 Jun 2020 14:57:47 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Antoine Brodin <antoine@freebsd.org> Cc: Jung-uk Kim <jkim@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r361770 - in head: include lib/libthr lib/libthr/thread share/man/man3 Message-ID: <20200604115747.GP48478@kib.kiev.ua> In-Reply-To: <CAALwa8mFKGMbsif1P-R9ru5E9Qx6zBKMSuxUBrJdehFLoPZo6A@mail.gmail.com> References: <202006032054.053KsbSs081539@repo.freebsd.org> <be6f3f8d-e53b-98c7-05b3-b798e04a1154@FreeBSD.org> <CAALwa8mFKGMbsif1P-R9ru5E9Qx6zBKMSuxUBrJdehFLoPZo6A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 04, 2020 at 07:51:42AM +0200, Antoine Brodin wrote:
> On Thu, Jun 4, 2020 at 4:30 AM Jung-uk Kim <jkim@freebsd.org> wrote:
> >
> > It broke Firefox build and I found Linux pthread_{get,set}name_np(3)
> > returns int.
> >
> > https://linux.die.net/man/3/pthread_getname_np
> >
> > I guess you need to write a wrapper. Please revert this patch for now.
>
> Hi,
>
> It broke devel/glib20 too, which now tries to use the function
> without including the header:
> http://beefy18.nyi.freebsd.org/data/head-amd64-default/p537862_s361780/logs/errors/glib-2.56.3_7,1.log
I reworked the change, please see the updated review
https://reviews.freebsd.org/D25117
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200604115747.GP48478>