Date: Sat, 08 Jan 2005 10:47:51 -0800 From: Nate Lawson <nate@root.org> To: Pawel Worach <pawel.worach@telia.com> Cc: John Baldwin <jhb@FreeBSD.org> Subject: Re: page fault panic in device_get_softc/acpi_pcib_route_interrupt Message-ID: <41E02AD7.5000005@root.org> In-Reply-To: <41DFA2FF.0@telia.com> References: <20587818.1102626838092.JavaMail.tomcat@pne-ps4-sn1> <41DEED05.4040000@root.org> <41DF0839.6040700@telia.com> <200501071728.16828.jhb@FreeBSD.org> <41DF2BB3.60800@root.org> <41DF347E.6010305@telia.com> <41DF5159.1090106@root.org> <41DF5DEA.3030904@telia.com> <41DF9481.5030305@root.org> <41DFA2FF.0@telia.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Worach wrote:
> Nate Lawson wrote:
>
>> [...] Change that to "acpi_get_device(handle)" and post the printout,
>> just so I can make sure this part is working overall.
>>
>
> Sure.
> adding child \_PR_.CPU1, dev 0xc1f7a180
> adding child \_PR_.CPU0, dev 0xc1f16e00
Ok, things are working fine (non-null devices).
> adding child \_SB_, dev 0xc1f16b80
This is not really a device and the patch I committed handles this.
> --- sys/dev/acpica/acpi_pcib.c 27 Dec 2004 05:36:47 -0000 1.53
> +++ sys/dev/acpica/acpi_pcib.c 8 Jan 2005 09:05:57 -0000
> @@ -249,11 +249,18 @@
> /*
> * We have to find the source device (PCI interrupt link device).
> */
> - if (ACPI_FAILURE(AcpiGetHandle(ACPI_ROOT_OBJECT, prt->Source,
> &lnkdev))) {
> + if (ACPI_FAILURE(AcpiGetHandle(acpi_get_handle(pcib), prt->Source,
> + &lnkdev))) {
> device_printf(pcib, "couldn't find PCI interrupt link device %s\n",
> prt->Source);
> goto out;
> }
This change should not be committed. I think it's correct to use \ to
start the search since your _PRT contains relative references but the
links are under \.
With the commit I made, you can revert all these patches, including the
custom ASL. It should work as before. Let me know if it doesn't.
--
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41E02AD7.5000005>