Date: Mon, 20 Feb 2012 16:37:29 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: Marcel Moolenaar <marcel@xcllnt.net>, Brooks Davis <brooks@freebsd.org>, net@freebsd.org Subject: Re: Abstracting struct ifnet Message-ID: <CAJ-Vmoni1DHpxet08=JWSDGLFBP7MHO4-WDBLwX9vGxibR=EDA@mail.gmail.com> In-Reply-To: <20120221001552.GA60050@onelab2.iet.unipi.it> References: <338757D1-6B1E-49CF-983F-5D5851066FD3@xcllnt.net> <20120220231601.GA51310@lor.one-eyed-alien.net> <20120221001552.GA60050@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 February 2012 16:15, Luigi Rizzo <rizzo@iet.unipi.it> wrote: >> The concept seems fine to me and I like that it might simplify future >> API changes. =A0Have you verified that if_get_*() accessors don't add >> significant overhead? > > the vast majority of these fields are only accessed in the control path, > not on each packet, so there isn't really a performance issue. Besides > they can be trivially implemted as macros or inline functions. I doubt Juniper need _binary_ level compatibility. So we could get away with inline methods. This sort of thing just makes source level compatibility a lot easier. Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmoni1DHpxet08=JWSDGLFBP7MHO4-WDBLwX9vGxibR=EDA>