Date: Thu, 25 Oct 2001 07:09:26 -0500 From: "Jacques A. Vidrine" <n@nectar.com> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/security/openssh Makefile ports/security/openssh/files patch-coredump ports/security/openssh-portable Makefile ports/security/openssh-portable/files patch-coredump Message-ID: <20011025070926.A73086@madman.nectar.com> In-Reply-To: <200110240716.f9O7GnQ17535@freefall.freebsd.org>; from dinoex@FreeBSD.org on Wed, Oct 24, 2001 at 12:16:49AM -0700 References: <200110240716.f9O7GnQ17535@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 24, 2001 at 12:16:49AM -0700, Dirk Meyer wrote:
> dinoex 2001/10/24 00:16:49 PDT
>
> Modified files:
> security/openssh Makefile
> security/openssh-portable Makefile
> Added files:
> security/openssh/files patch-coredump
> security/openssh-portable/files patch-coredump
> Log:
> - included an patch that solves a coredump in sshd
> - Bumped PORTREVISION
Please do not use more than one patch file per source file. Now both
`patch-session.c' and `patch-coredump' modify `session.c'.
Also, do you have more information on the problem that is supposedly
solved by this patch? The patch simply initializes `env' to NULL.
However, `env' is not used before being initialized that I can see.
Did I miss something?
void
do_child(Session *s, const char *command)
{
[... the patch makes this change ...]
- char **env;
+ char **env = NULL;
[... first reference to env follows ...]
envsize = 100;
env = xmalloc(envsize * sizeof(char *));
Cheers,
--
Jacques A. Vidrine <n@nectar.com> http://www.nectar.com/
Verio Web Hosting = FreeBSD UNIX = Heimdal Kerberos
jvidrine@verio.net = nectar@FreeBSD.org = nectar@pdc.kth.se
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011025070926.A73086>