Date: Sun, 4 Sep 2022 06:39:53 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e72c522858cb - main - divert(4): make it compilable and working without INET Message-ID: <15on1poo-pnpq-3pos-qs7s-673pp1q0s83@serrofq.bet> In-Reply-To: <YxQ9Shj2Em3oe92s@FreeBSD.org> References: <202208302249.27UMnSwI022109@gitrepo.freebsd.org> <6q6n8553-2143-n24p-4816-406549997s@mnoonqbm.arg> <YxQ9Shj2Em3oe92s@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 3 Sep 2022, Gleb Smirnoff wrote: > On Sat, Sep 03, 2022 at 10:44:26PM +0000, Bjoern A. Zeeb wrote: > B> On Tue, 30 Aug 2022, Gleb Smirnoff wrote: > B> > B> > The branch main has been updated by glebius: > B> > > B> > URL: https://cgit.FreeBSD.org/src/commit/?id=e72c522858cb3fe179b8ec5700cdbf46c45e917e > B> > > B> > commit e72c522858cb3fe179b8ec5700cdbf46c45e917e > B> > Author: Gleb Smirnoff <glebius@FreeBSD.org> > B> > AuthorDate: 2022-08-30 22:09:21 +0000 > B> > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > B> > CommitDate: 2022-08-30 22:09:21 +0000 > B> > > B> > divert(4): make it compilable and working without INET > B> > > B> > Differential revision: https://reviews.freebsd.org/D36383 > B> > B> Well, almost at least.... > > I wonder why LINT-NOINET builds without this?? I wondered the same last night.. I would be good to find out? > B> - sysctls require INET > > The sysctls, I believe, need to be moved out of the inet namespace. > > B> - ip_divert_ptr still requires INET or INET6 (raw_ip.c) > > This dependency is fine as it is. Packet filters also require either. Also, > I don't expect that through my lifetime we would ever need a kernel with > network stack features, but without both INET and INET6. There are people who build kernels w/o networking (hence LINT-NOIP) which is what found this one. > B> - one of the SCTP blocks has a early-ended #ifdef INET which can just be > B> fixed easily compared to the two above. > > Thanks! > > I'll post a review soon. Cool. Thank you! Blessed Sunday. /bz -- Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15on1poo-pnpq-3pos-qs7s-673pp1q0s83>