Date: Sat, 6 Sep 2008 08:04:01 +0200 (CEST) From: freebsdntpd@oldach.net (Helge Oldach) To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Ollivier Robert <roberto@FreeBSD.org> Subject: Re: bin/92839: contrib/ntp PARSE buffer overrun [patch] Message-ID: <200809060604.m86642xN005776@sep.oldach.net> In-Reply-To: <200602051330.k15DU3DT001208@freefall.freebsd.org> from "FreeBSD-gnats-submit@FreeBSD.org" at "5 Feb 2006 13:30:03"
next in thread | previous in thread | raw e-mail | index | archive | help
After Ollivier's recent update of ntp two buffer overruns still remain.
The patch below fixes them:
--- clk_rawdcf.c 2008-09-06 07:59:47.000000000 +0200
+++ clk_rawdcf.c.ctm 2008-09-04 23:01:34.000000000 +0200
@@ -229,7 +229,7 @@
unsigned char *c = dcfprm->zerobits;
int i;
- parseprintf(DD_RAWDCF,("parse: convert_rawdcf: \"%.*s\"\n", size, buffer));
+ parseprintf(DD_RAWDCF,("parse: convert_rawdcf: \"%s\"\n", buffer));
if (size < 57)
{
@@ -320,7 +320,7 @@
* bad format - not for us
*/
#ifndef PARSEKERNEL
- msyslog(LOG_ERR, "parse: convert_rawdcf: parity check FAILED for \"%.*s\"\n", size, buffer);
+ msyslog(LOG_ERR, "parse: convert_rawdcf: parity check FAILED for \"%s\"\n", buffer);
#endif
return CVT_FAIL|CVT_BADFMT;
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809060604.m86642xN005776>