Date: Fri, 14 Sep 2012 08:19:05 -0400 From: John Baldwin <jhb@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Attilio Rao <attilio@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern Message-ID: <201209140819.06026.jhb@freebsd.org> In-Reply-To: <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> References: <201209132226.q8DMQMFC088169@svn.freebsd.org> <20120914042031.GZ37286@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, September 14, 2012 12:20:31 am Konstantin Belousov wrote: > On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: > > Author: attilio > > Date: Thu Sep 13 22:26:22 2012 > > New Revision: 240475 > > URL: http://svn.freebsd.org/changeset/base/240475 > > > > Log: > > Remove all the checks on curthread != NULL with the exception of some MD > > trap checks (eg. printtrap()). > > > > Generally this check is not needed anymore, as there is not a legitimate > > case where curthread != NULL, after pcpu 0 area has been properly > > initialized. > I do not disagree with the patch, but I do with this statement. > During the AP startup, there is indeed a window while curthread is NULL. > Unfortunately, trying to panic there is worse then not panic. Also during early BSP startup. On x86 very early faults actually result in a BTX fault rather than a panic since we run with BTX's IDT for a bit in locore, etc. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209140819.06026.jhb>