Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Sep 2025 13:37:49 -0700
From:      "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To:        Lexi Winter <ivy@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 9537aa02f404 - main - packages: Mark all sets as vital
Message-ID:  <B950ADA7-6F85-43CA-A3DB-577928DA3B14@gmail.com>
In-Reply-To: <202509172032.58HKWfxp028171@gitrepo.freebsd.org>
References:  <202509172032.58HKWfxp028171@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On Sep 17, 2025, at 1:32 PM, Lexi Winter <ivy@FreeBSD.org> wrote:
> 
> The branch main has been updated by ivy:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=9537aa02f40454ba8243e8c877695876d3e4c150
> 
> commit 9537aa02f40454ba8243e8c877695876d3e4c150
> Author:     Lexi Winter <ivy@FreeBSD.org>
> AuthorDate: 2025-09-17 20:12:21 +0000
> Commit:     Lexi Winter <ivy@FreeBSD.org>
> CommitDate: 2025-09-17 20:14:18 +0000

…

> diff --git a/release/packages/sets/src.ucl b/release/packages/sets/src.ucl
> index eada5dbde641..7ab94eb420df 100644
> --- a/release/packages/sets/src.ucl
> +++ b/release/packages/sets/src.ucl
> @@ -1,5 +1,7 @@
> comment = "System source code"
> 
> +vital = yes
> +
> desc = <<EOD
> This metapackage installs source code for the base system and kernel.
> EOD
> diff --git a/release/packages/sets/tests.ucl b/release/packages/sets/tests.ucl
> index 88426a54a807..07b463fb7d69 100644
> --- a/release/packages/sets/tests.ucl
> +++ b/release/packages/sets/tests.ucl
> @@ -1,5 +1,7 @@
> comment = "System test suite"
> 
> +vital = yes
> +
> desc = <<EOD
> This metapackage installs the system test suite.
> EOD


Hi Lexi!
	I actually wouldn’t consider `src` or `tests` to be vital (many users don’t install them on their systems). Is there a reason why they should be considered vital that I’m not aware of? I’ve not been paying a ton of attention to work being done in the pkg-base space, so I might have missed some important points.
Thank you!
-Enji


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B950ADA7-6F85-43CA-A3DB-577928DA3B14>