Date: Thu, 16 Jun 2016 12:15:03 -0600 From: Ian Lepore <ian@freebsd.org> To: Ngie Cooper <yaneurabeya@gmail.com>, cem@freebsd.org Cc: Konstantin Belousov <kib@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301959 - head/sys/kern Message-ID: <1466100903.51702.5.camel@freebsd.org> In-Reply-To: <E27E4A0B-949C-4DCA-A9D4-B3B822E13C18@gmail.com> References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com> <E27E4A0B-949C-4DCA-A9D4-B3B822E13C18@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2016-06-16 at 10:43 -0700, Ngie Cooper wrote:
> > On Jun 16, 2016, at 10:17, Conrad Meyer <cem@freebsd.org> wrote:
> >
> > > On Thu, Jun 16, 2016 at 4:58 AM, Konstantin Belousov <
> > > kib@freebsd.org> wrote:
> > > --- head/sys/kern/kern_thread.c Thu Jun 16 11:55:24 2016
> > > (r301958)
> > > +++ head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016
> > > (r301959)
> > > @@ -669,11 +669,6 @@ weed_inhib(int mode, struct thread *td2,
> > > wakeup_swapper |= sleepq_abort(td2,
> > > EINTR);
> > > break;
> > > case SINGLE_BOUNDARY:
> > > - if (TD_IS_SUSPENDED(td2) && (td2->td_flags &
> > > TDF_BOUNDARY) == 0)
> > > - wakeup_swapper |=
> > > thread_unsuspend_one(td2, p, false);
> > > - if (TD_ON_SLEEPQ(td2) && (td2->td_flags &
> > > TDF_SINTR) != 0)
> > > - wakeup_swapper |= sleepq_abort(td2,
> > > ERESTART);
> > > - break;
> >
> > style(9) nit: /* FALLTHROUGH */
> >
> Also, coverity will complain about the missing break unless that's
> there...
>
If coverity complains about
case 1:
case 2:
statements;
break;
then it is coverity that needs to be fixed.
-- Ian
> > Best,
> > Conrad
> >
> > > case SINGLE_NO_EXIT:
> > > if (TD_IS_SUSPENDED(td2) && (td2->td_flags &
> > > TDF_BOUNDARY) == 0)
> > > wakeup_swapper |=
> > > thread_unsuspend_one(td2, p, false);
> >
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1466100903.51702.5.camel>