Date: Wed, 31 Dec 2014 21:20:01 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, Warner Losh <imp@FreeBSD.org>, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Dimitry Andric <dim@FreeBSD.org> Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf Message-ID: <4F74425F-68B9-4BA2-A962-6C1AA77B4C75@gmail.com> In-Reply-To: <A002DA3A-0047-4F83-8896-25AEEBF489A3@gmail.com> References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> <E1FA7448-844B-4454-8C2C-5592198D0570@gmail.com> <FC1DD917-D28C-44B8-9BE8-45A57F4A9EA6@bsdimp.com> <E041E7F2-CC45-4D7B-912F-E5F86772E44A@gmail.com> <A002DA3A-0047-4F83-8896-25AEEBF489A3@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Dec 31, 2014, at 21:12, Garrett Cooper <yaneurabeya@gmail.com> wrote:
> On Dec 31, 2014, at 20:44, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>
>> On Dec 31, 2014, at 20:25, Warner Losh <imp@bsdimp.com> wrote:
>
> …
>
>>> This change is wrong. bsd.sys.mk was eliminated on purpose, dammit.
>>
>> Sorry. Should have asked first. Now the build is broken on all architectures :/. What next?
>
> Also, that code has been in there for over a decade. It seems a bit dangerous to remove it without at least a ports -exp or make tinderbox run…
Hmmm… would it make sense to disable clang warnings from within bsd.sys.mk, like we do with sparc64?
Thanks!
117 .if ${MACHINE_CPUARCH} == "sparc64"
118 # Don't emit .cfi directives, since we must use GNU as on sparc64, for now.
119 CFLAGS.clang+= -fno-dwarf2-cfi-asm
120 .endif # SPARC64
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJUpNkBAAoJEMZr5QU6S73eHBAH/0kn+vGupJqlebuLt77IGurg
MwbEwYhr3sDjUhWlvhnpvr+AFzcaRVeqKo6qhFk1wZf6M0jRUH486L0D1B+FqOwF
z1A6jMS0Y+PULIzkEEBGLhiN9g/v9vDreJgvZ/iq3YT4YRdhOOkUFrzMGThLMChE
hDjN7SDZaw5BZilWWYRkTXQ1AqWXNqgVh82GXzRwAxhviDkQLEO8ydQKmcGx3ese
dY4bLotw/ql6g0gVdta8KlowglKMpBwC0mlrCg6ccXocPoOLrLYjBAD/yyRvvnWb
nt2IIpsa6XtBxUKC5bzkPCs3ggoTKQmH67C0JwoSGoU3q+D66duELu9HHhJnDLc=
=FGFq
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F74425F-68B9-4BA2-A962-6C1AA77B4C75>