Date: Sat, 9 Sep 2017 12:45:39 -0600 From: Sean Bruno <sbruno@freebsd.org> To: Ian Lepore <ian@freebsd.org>, Marcin Wojtas <mw@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323359 - in head/sys: conf dev/uart modules/uart Message-ID: <2ace05fc-4dc9-494a-8e6f-27fa9f1ebf97@freebsd.org> In-Reply-To: <1504981201.32063.59.camel@freebsd.org> References: <201709091142.v89BgX8e090592@repo.freebsd.org> <c25c2924-40a0-d5b3-43fe-8e83df185146@freebsd.org> <1504981201.32063.59.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PgrKGr1XvWJIgXJwnbfB34GqW9lVosu4S Content-Type: multipart/mixed; boundary="0fNMiaW6nTqH0BK6WHVE3vIsC7pmuKBku"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: Ian Lepore <ian@freebsd.org>, Marcin Wojtas <mw@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <2ace05fc-4dc9-494a-8e6f-27fa9f1ebf97@freebsd.org> Subject: Re: svn commit: r323359 - in head/sys: conf dev/uart modules/uart References: <201709091142.v89BgX8e090592@repo.freebsd.org> <c25c2924-40a0-d5b3-43fe-8e83df185146@freebsd.org> <1504981201.32063.59.camel@freebsd.org> In-Reply-To: <1504981201.32063.59.camel@freebsd.org> --0fNMiaW6nTqH0BK6WHVE3vIsC7pmuKBku Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 09/09/17 12:20, Ian Lepore wrote: > On Sat, 2017-09-09 at 12:09 -0600, Sean Bruno wrote: >> >> On 09/09/17 05:42, Marcin Wojtas wrote: >>> >>> Author: mw >>> Date: Sat Sep 9 11:42:32 2017 >>> New Revision: 323359 >>> URL: https://svnweb.freebsd.org/changeset/base/323359 >>> >>> Log: >>> Introduce UART driver module for Armada 3700 >>> =20 >>> This patch adds support for UART in Armada 3700 family. >>> It exposes both low-level UART interface, as well as >>> standard driver methods. >>> =20 >>> Submitted by: Patryk Duda <pdk@semihalf.com> >>> Obtained from: Semihalf >>> Sponsored by: Semihalf >>> Differential Revision: https://reviews.freebsd.org/D12250 >>> >>> Added: >>> head/sys/dev/uart/uart_dev_mvebu.c (contents, props changed) >>> Modified: >>> head/sys/conf/files >>> head/sys/modules/uart/Makefile >> >> Hrm ... I seem to be getting a compile failure after this: >> >> cc -target x86_64-unknown-freebsd12.0 --sysroot=3D/var/tmp/usr/src/tmp= >> -B/var/tmp/usr/src/tmp/usr/bin -O2 -pipe -fno-strict-aliasing >> -Werror >> -D_KERNEL -DKLD_MODULE -nostdinc -DHAVE_KERNEL_OPTION_HEADERS >> -include >> /var/tmp/usr/src/sys/GENERIC-NODEBUG/opt_global.h -I. -I/usr/src/sys >> -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer >> -I/var/tmp/usr/src/sys/GENERIC-NODEBUG -MD >> -MF.depend.uart_dev_mvebu.o -MTuart_dev_mvebu.o -mcmodel=3Dkernel >> -mno-red-zone -mno-mmx -mno-sse -msoft-float >> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack- >> protector >> -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict- >> prototypes >> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef >> -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ >> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas >> -Wno-error-tautological-compare -Wno-error-empty-body >> -Wno-error-parentheses-equality -Wno-error-unused-function >> -Wno-error-pointer-sign -Wno-error-shift-negative-value >> -Wno-error-address-of-packed-member -mno-aes -mno-avx >> -std=3Diso9899:1999 -c /usr/src/sys/dev/uart/uart_dev_mvebu.c -o >> uart_dev_mvebu.o >> In file included from /usr/src/sys/dev/uart/uart_dev_mvebu.c:39: >> /usr/src/sys/dev/ofw/ofw_bus_subr.h:40:10: fatal error: >> 'ofw_bus_if.h' >> file not found >> #include "ofw_bus_if.h" >> ^~~~~~~~~~~~~~ >> 1 error generated. >> *** Error code 1 >> >> Is there supposed to be processing of ofw_bus_if.m somewhere that is >> currently missed? >> >> sean >> >=20 > ofw_bus_if.h needs to be added to SRCS=3D in the module makefile. Over= > the years I learned to grep the c files for _if.h to figure out what > generated files to add to a module makefile, but ofw_bus_if.h is > insidious -- it gets included from ofw_bus_subr.h so nobody includes it= > directly and it always gets missed in new module makefiles. >=20 > -- Ian >=20 >=20 >=20 Oh, the SRCS entry *is* in sys/modules/uart/Makefile but not for x86 archs. Should this even be built for x86? sean --0fNMiaW6nTqH0BK6WHVE3vIsC7pmuKBku-- --PgrKGr1XvWJIgXJwnbfB34GqW9lVosu4S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlm0NtNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /Lbo5wgAju2u5HWee3e7GKUDrioMpkKcnARpy3Pw89SKT6dKYKBtPccmVFQ2MtGY qt1wI5ymW4haoejOpNId0P2m0ZMCwllWUgEjV4LMLcE7T46cYxtxALCmATj16iRU E6VY51c5UkpMli2pPHW2swKuSuY0scyrxFrLR6yAx06ldoz6eAh78+GcL4hJYTfK B6PYACo9VQRyREjzys9NjKXTsUx3aCHA1GQTmEfwlS9YVsHNASu697cFGs4JihSf 9CBPXAsQNRykrEL02kPLgxBWDqvDFy3556kvyQIcQgkQj0HqME/l7u9P239h+lUR BSctRbjbeoP1jPYr1c4SWdc5d/6Ywg== =c15W -----END PGP SIGNATURE----- --PgrKGr1XvWJIgXJwnbfB34GqW9lVosu4S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2ace05fc-4dc9-494a-8e6f-27fa9f1ebf97>