Date: Wed, 14 Jan 2009 22:56:59 +0000 (UTC) From: Sam Leffler <sam@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r187254 - projects/vap7/sbin/ifconfig Message-ID: <200901142256.n0EMuxWq056439@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: sam Date: Wed Jan 14 22:56:59 2009 New Revision: 187254 URL: http://svn.freebsd.org/changeset/base/187254 Log: mfc r187253: use correct interface name when setting flags Modified: projects/vap7/sbin/ifconfig/ (props changed) projects/vap7/sbin/ifconfig/ifconfig.c Modified: projects/vap7/sbin/ifconfig/ifconfig.c ============================================================================== --- projects/vap7/sbin/ifconfig/ifconfig.c Wed Jan 14 22:55:49 2009 (r187253) +++ projects/vap7/sbin/ifconfig/ifconfig.c Wed Jan 14 22:56:59 2009 (r187254) @@ -697,13 +697,13 @@ setifflags(const char *vname, int value, struct ifreq my_ifr; int flags; - bcopy((char *)&ifr, (char *)&my_ifr, sizeof(struct ifreq)); + memset(&my_ifr, 0, sizeof(my_ifr)); + (void) strlcpy(my_ifr.ifr_name, name, sizeof(my_ifr.ifr_name)); if (ioctl(s, SIOCGIFFLAGS, (caddr_t)&my_ifr) < 0) { Perror("ioctl (SIOCGIFFLAGS)"); exit(1); } - strncpy(my_ifr.ifr_name, name, sizeof (my_ifr.ifr_name)); flags = (my_ifr.ifr_flags & 0xffff) | (my_ifr.ifr_flagshigh << 16); if (value < 0) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901142256.n0EMuxWq056439>