Date: Mon, 27 Oct 2003 15:21:45 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Hajimu UMEMOTO <ume@mahoroba.org> Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Subject: Re: cvs commit: src/sys/netinet icmp6.h ip6.h src/sys/netinet6 in6.h Message-ID: <20031027151510.F21211@gamplex.bde.org> In-Reply-To: <ygehe1wi804.wl%ume@mahoroba.org> References: <200310251057.h9PAv8pn086818@repoman.freebsd.org> <20031025192855.GA96324@rot13.obsecurity.org> <20031026040132.GA2036@rot13.obsecurity.org> <20031026050059.GA2206@rot13.obsecurity.org> <20031026162715.I17272@gamplex.bde.org> <ygehe1wi804.wl%ume@mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 26 Oct 2003, Hajimu UMEMOTO wrote: > >>>>> On Sun, 26 Oct 2003 16:38:38 +1100 (EST) > >>>>> Bruce Evans <bde@zeta.org.au> said: > > bde> - the closure of the changes for <netinet/in.h> apparently included > bde> some KAME headers. > > I found that there was one use of u_int32_t in newly introduced struct > definition. I've just correct to use uint32_t. I believe it fix the > problem. Sorry for the mess. There are also lots of u_int32_t's in #defines in at least <netinet/in.h>. These don't prevent including the header without a prior include of <sys/types.h>, but they prevent using the macros. There are also some u_char's in comments. Many of the macros are not fully parenthesized. E.g.: #define INADDR_ANY (u_int32_t)0x00000000 #define IP_MULTICAST_IF 9 /* u_char; set/get IP multicast i/f */ Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031027151510.F21211>