Date: Fri, 5 Aug 2011 10:10:29 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Brendan Fabeny <bf@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/youtube_dl Makefile distinfo Message-ID: <20110805021028.GD12696@bonjour.sunpoet.net> In-Reply-To: <201108042336.p74NaqwG020915@repoman.freebsd.org> References: <201108042336.p74NaqwG020915@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 04, 2011 at 11:36:52PM +0000, Brendan Fabeny wrote:
> bf 2011-08-04 23:36:52 UTC
>
> FreeBSD ports repository
>
> Modified files:
> www/youtube_dl Makefile distinfo
> Log:
> update to 2011-08-04
>
> Approved by: araujo
>
> Revision Changes Path
> 1.58 +3 -3 ports/www/youtube_dl/Makefile
> 1.48 +2 -2 ports/www/youtube_dl/distinfo
Hi,
I noticed that you change ${DISTDIR}/${DIST_SUBDIR} to ${_DISTDIR}.
IMHO, it would be better not to use _foo variables as they are named for
internal use.
Thanks.
- sunpoet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110805021028.GD12696>