Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Sep 2022 15:57:07 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Gordon Bergling <gbe@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 94466c432ed6 - main - Revert "usb: Remove a double words in a source code comments"
Message-ID:  <YxYcUxdLE6zxbbL8@FreeBSD.org>
In-Reply-To: <202209051346.285Dk4BC013542@gitrepo.freebsd.org>
References:  <202209051346.285Dk4BC013542@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 05, 2022 at 01:46:04PM +0000, Gordon Bergling wrote:
> commit 94466c432ed611a49cacae7ff99b224b37c906bb
> 
>   Revert "usb: Remove a double words in a source code comments"
>     
>   This reverts commit 8ca67bf1273a5168f8a3787183159c477632e582.
>     
>   The original comment was correct; changing it loses a key part.
>     
>   Reported by:    jrtc27

jrtc27@ had pointed out two places, but you've reverted all three.

> - *	different from the muge_init() function in that one is designed to
> + *	different from the muge_init() function in that that one is designed to

Admittedly, I'd rather see the whole comment rephrased: these double thats
make it hard to read and just begging for someone, perhaps even you, "fix"
it again in the future. :)

> -		 * We assume that the alignment at this point of
> +		 * We assume that that the alignment at this point of

This one had not been complained about, I think.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YxYcUxdLE6zxbbL8>