Date: Wed, 25 Apr 2007 14:41:00 -0400 From: Stephan Uphoff <ups@freebsd.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann <andre@FreeBSD.org>, cvs-all@FreeBSD.org, Coleman Kane <cokane@FreeBSD.org> Subject: Re: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c Message-ID: <462FA0BC.8020207@freebsd.org> In-Reply-To: <20070424091858.GA31094@comp.chem.msu.su> References: <200704211417.l3LEHUKK078832@repoman.freebsd.org> <462A27CD.5090006@freebsd.org> <1177170852.32761.0.camel@localhost> <20070424091858.GA31094@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
Yar Tikhiy wrote: > On Sat, Apr 21, 2007 at 09:54:12AM -0600, Coleman Kane wrote: > >> On Sat, 2007-04-21 at 17:03 +0200, Andre Oppermann wrote: >> >>> Stephan Uphoff wrote: >>> >>>> ups 2007-04-21 14:17:30 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/amd64/amd64 pmap.c >>>> sys/i386/i386 pmap.c >>>> Log: >>>> Modify TLB invalidation handling. >>>> >>>> Reviewed by: alc@, peter@ >>>> MFC after: 1 week >>>> >>> Could you be a bit more verbose what changed here and why it >>> was done? >>> >>> >> I agree. I would really like to know what the modification accomplishes. >> > > Alas, we don't live in an ideal world. If we did, our commit > messages would always follow the well-known guideline: > > 0. Tell the essence of the change. > 1. Give the reason for the change. > 2. Explain the change unless it's trivial. > > In the ideal world there are no NDAs :-) As planned I forced a commit with a better comment once I was able to. Thanks for your patients, Stephan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?462FA0BC.8020207>