Date: Wed, 22 Aug 2001 11:50:24 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: cjclark@alum.mit.edu Cc: freebsd-audit@FreeBSD.ORG Subject: Re: syslogd(8) Hostname Upgrade Message-ID: <20010822115024.A23430@sunbay.com> In-Reply-To: <20010822013841.A76483@blossom.cjclark.org>; from cristjc@earthlink.net on Wed, Aug 22, 2001 at 01:38:41AM -0700 References: <20010822013841.A76483@blossom.cjclark.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 22, 2001 at 01:38:41AM -0700, Crist J. Clark wrote:
[...]
> + if (gethostname(LocalHostName, sizeof(LocalHostName)))
Check explicitly against -1.
> + err(EX_OSERR, "gethostname failed");
Add "()" after "gethostname".
> + if (signo && strcmp(oldLocalHostName, LocalHostName)) {
I'm always confused when seeing this. IMHO, ``strcmp(...) != 0''
is much better.
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010822115024.A23430>