Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Jun 2018 08:52:22 +0000 (UTC)
From:      Eitan Adler <eadler@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r335043 - head/usr.bin/top
Message-ID:  <201806130852.w5D8qMin094627@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eadler
Date: Wed Jun 13 08:52:22 2018
New Revision: 335043
URL: https://svnweb.freebsd.org/changeset/base/335043

Log:
  top(1): style(9)
  
  - split return type from function name
  - Sprinkle a __pure where possible.

Modified:
  head/usr.bin/top/display.c
  head/usr.bin/top/username.c
  head/usr.bin/top/utils.c

Modified: head/usr.bin/top/display.c
==============================================================================
--- head/usr.bin/top/display.c	Wed Jun 13 08:52:19 2018	(r335042)
+++ head/usr.bin/top/display.c	Wed Jun 13 08:52:22 2018	(r335043)
@@ -160,7 +160,8 @@ display_resize(void)
     return(smart_terminal ? lines : Largest);
 }
 
-int display_updatecpus(struct statics *statics)
+int
+display_updatecpus(struct statics *statics)
 {
     int lines;
     int i;
@@ -184,7 +185,8 @@ int display_updatecpus(struct statics *statics)
     return(lines);
 }
 
-int display_init(struct statics * statics)
+int
+display_init(struct statics * statics)
 {
     int lines;
     char **pp;
@@ -1074,7 +1076,8 @@ readline(char *buffer, int size, int numeric)
 
 /* internal support routines */
 
-static void summary_format(char *str, int *numbers, const char * const *names)
+static void
+summary_format(char *str, int *numbers, const char * const *names)
 {
     char *p;
     int num;

Modified: head/usr.bin/top/username.c
==============================================================================
--- head/usr.bin/top/username.c	Wed Jun 13 08:52:19 2018	(r335042)
+++ head/usr.bin/top/username.c	Wed Jun 13 08:52:22 2018	(r335043)
@@ -55,7 +55,8 @@ struct hash_el {
 static struct hash_el hash_table[Table_size];
 
 
-char *username(int uid)
+char *
+username(int uid)
 {
     int hashindex;
 
@@ -68,7 +69,8 @@ char *username(int uid)
     return(hash_table[hashindex].name);
 }
 
-int userid(char username[])
+int
+userid(char username[])
 {
     struct passwd *pwd;
 
@@ -89,7 +91,8 @@ int userid(char username[])
 }
 
 /* wecare 1 = enter it always, 0 = nice to have */
-int enter_user(int uid, char name[], bool wecare)
+int
+enter_user(int uid, char name[], bool wecare)
 {
     int hashindex;
 

Modified: head/usr.bin/top/utils.c
==============================================================================
--- head/usr.bin/top/utils.c	Wed Jun 13 08:52:19 2018	(r335042)
+++ head/usr.bin/top/utils.c	Wed Jun 13 08:52:22 2018	(r335043)
@@ -122,7 +122,7 @@ digits(int val)
  * string_index(string, array) - find string in array and return index
  */
 
-int
+int __pure
 string_index(const char *string, const char * const *array)
 {
     size_t i = 0;
@@ -175,7 +175,7 @@ argparse(char *line, int *cntp)
  *	useful on for calculating cpu state percentages.
  */
 
-long
+long __pure
 percentages(int cnt, int *out, long *new, long *old, long *diffs)
 {
     int i;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806130852.w5D8qMin094627>