Date: Mon, 9 Dec 2013 17:11:05 +0100 (CET) From: Christian Weisgerber <naddy@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Subject: kern/184638: ncurses: bump ospeed from short to int Message-ID: <201312091611.rB9GB5E3074985@lorvorc.mips.inka.de> Resent-Message-ID: <201312091650.rB9Go0og050329@freefall.freebsd.org>
index | next in thread | raw e-mail
>Number: 184638 >Category: kern >Synopsis: ncurses: bump ospeed from short to int >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Dec 09 16:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Christian Weisgerber >Release: FreeBSD 9.2-STABLE amd64 >Organization: >Environment: System: FreeBSD lorvorc.mips.inka.de 9.2-STABLE FreeBSD 9.2-STABLE #0 r259069: Sat Dec 7 15:52:28 CET 2013 naddy@lorvorc.mips.inka.de:/usr/obj/usr/src/sys/GENERIC amd64 >Description: In FreeBSD (all supported versions) the type of the ospeed variable is defined as "short" in lib/ncurses/ncurses/Makefile. However, in contrib/ncurses/ncurses/tinfo/lib_baudrate.c the USE_OLD_TTY hack is disabled for FreeBSD >=7 since the required 4.3BSD compatibility goo went away. As a result, ospeed now needs to be able to hold values up to 921600 (cf. <sys/_termios.h>), so it must be bumped from short to int. Obviously this is a binary-incompatible API change. Arguably, switching ospeed's type is more intrusive than having garbage values in ospeed, but we should strive for correctness. (FWIW, OpenBSD, which is facing the same issue, will switch to int ospeed.) >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted:help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312091611.rB9GB5E3074985>