Date: Thu, 07 Mar 2002 11:30:47 +0000 From: Mark Murray <mark@grondar.za> To: obrien@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/dd args.c dd.c dd.h Message-ID: <200203071130.g27BUlRV009426@grimreaper.grondar.org> In-Reply-To: <20020307030821.C63484@dragon.nuxi.com> ; from "David O'Brien" <obrien@FreeBSD.org> "Thu, 07 Mar 2002 03:08:21 PST." References: <20020307030821.C63484@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, Feb 22, 2002 at 12:51:00PM -0800, Mark Murray wrote: > > markm 2002/02/22 12:51:00 PST > > > > Modified files: > > bin/dd args.c dd.c dd.h > > Log: > > Fix warnings inspired by lint, a commercial lint and WARNS=4. > > Why was this needed? > > -u_int ddflags; /* conversion options */ > +u_int ddflags = 0; /* conversion options */ "Uninitialised" or "Potentially uninitialised". > ddflags was *already* `0' as it was in the BSS. By initializing it, you > moved it into the data section which takes up more room in the binary. > (unless the compiler is smart enough to notice the initizliation is to > `0' and puts it back into the BSS). > Granted one int is not going to break the disk space bank. But you are > making arbitrary changes to good working code with decades of proven use. And potentially unproven bugs. I want to get the warning count down to somewhere where bugs show through. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203071130.g27BUlRV009426>