Date: Fri, 14 Aug 2009 00:55:28 +0300 From: Artis Caune <artis.caune@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: "Bjoern A. Zeeb" <bz@freebsd.org>, freebsd-current@freebsd.org Subject: Re: svn commit: r190514 - head/sys/conf Message-ID: <9e20d71e0908131455x62e2d26au52b3e5b0253cdaec@mail.gmail.com> In-Reply-To: <4A846206.7010803@FreeBSD.org> References: <200903282317.n2SNHIjI015202@svn.freebsd.org> <4A846206.7010803@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/8/13 Doug Barton <dougb@freebsd.org>:
>> =C2=A0if [ -n "$svnversion" -a -d "${SRCDIR}/.svn" ] ; then
>> - =C2=A0 =C2=A0 svn=3D" r`cd $SRCDIR && $svnversion`"
>> + =C2=A0 =C2=A0 # If we are called from the kernel build, limit
>> + =C2=A0 =C2=A0 # the scope of svnversion to sys/ .
>> + =C2=A0 =C2=A0 if [ -e "${SRCDIR}/sys/conf/newvers.sh" ] ; then
>
> I missed this when it went through originally, so my apologies for the
> late response, but I don't see any way that this first test can ever
> not be true. Is there a better way to detect if the script is called
> in the buildkernel process?
>
> Also, what problem are we really trying to solve here? With a
> populated cache it takes on average 5 seconds to run all of src, and
> just under 1 to do only sys. Is 4 seconds really that important to
> save? With a dry cache I'm sure it takes a little longer, but has
> anyone actually measured this?
How about 'svn info' ?
It will also hide M,S suffixes for modified and/or switched working copies.
svn=3D" r`svn info $SRCDIR 2>/dev/null | awk '/^Revision:/ {print $2}'`"
--=20
Artis Caune
Everything should be made as simple as possible, but not simpler.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9e20d71e0908131455x62e2d26au52b3e5b0253cdaec>