Date: Sat, 8 Sep 2001 20:47:29 -0400 From: Mike Barcroft <mike@FreeBSD.ORG> To: David Hill <david@phobia.ms> Cc: audit@FreeBSD.ORG Subject: Re: users.c PATCH - please review Message-ID: <20010908204729.A15754@coffee.q9media.com> In-Reply-To: <20010901125802.F85574@coffee.q9media.com>; from mike@FreeBSD.ORG on Sat, Sep 01, 2001 at 12:58:02PM -0400 References: <20010831160414.7125e88e.david@phobia.ms> <20010901125802.F85574@coffee.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Barcroft <mike@FreeBSD.ORG> writes:
> David Hill <david@phobia.ms> writes:
> > I have patched users/users.c so that it will compile under WARNS?=2. I have both attached and cut/pasted it to the message.
> > Please review it.
>
> > diff -ru /usr/src/usr.bin/users.orig/users.c /usr/src/usr.bin/users/users.c
> > --- /usr/src/usr.bin/users.orig/users.c Fri Aug 27 21:07:14 1999
> > +++ /usr/src/usr.bin/users/users.c Fri Aug 31 15:58:20 2001
> > @@ -117,5 +117,8 @@
> > scmp(p, q)
> > const void *p, *q;
> > {
> > - return(strncmp((char *)p, (char *)q, UT_NAMESIZE));
> > + const char *const pp1 = p;
> > + const char *const pp2 = q;
> > +
> > + return(strncmp(pp1, pp2, UT_NAMESIZE));
> > }
>
> Why create new local variables? Just get rid of the bogus casts.
Committed (with casts removed instead of the new variables), thanks!
Best regards,
Mike Barcroft
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010908204729.A15754>