Date: Wed, 20 Mar 2002 10:12:29 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Mark Murray <markm@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/share/mk bsd.lib.mk sys.mk src/sys/conf kern.post.mk kmod.mk Message-ID: <20020320100322.N7832-100000@gamplex.bde.org> In-Reply-To: <20020319115306.GE87672@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 19 Mar 2002, Ruslan Ermilov wrote:
> On Tue, Mar 19, 2002 at 08:05:43AM +1100, Bruce Evans wrote:
> > On Mon, 18 Mar 2002, Ruslan Ermilov wrote:
> >
> > > %%%
> > > Index: share/mk/bsd.lib.mk
> > > ===================================================================
> > > RCS file: /home/ncvs/src/share/mk/bsd.lib.mk,v
> > > retrieving revision 1.104
> > > diff -u -r1.104 bsd.lib.mk
> > > --- share/mk/bsd.lib.mk 17 Mar 2002 10:05:57 -0000 1.104
> > > +++ share/mk/bsd.lib.mk 18 Mar 2002 08:49:52 -0000
> > > ...
> > > @@ -375,9 +374,8 @@
> > >
> > > .if !target(lint)
> > > lint: ${SRCS:M*.c} _SUBDIR
> > > - ${LINT} ${LINTOBJFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC} | more 2>&1
> > > + ${LINT} ${LINTOBJFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC}
> >
> > Mark wanted to keep all these. I removed all the "more" pipelines, but
> > left the redirections. Now the redirection actually works (lint's error
> > output should have been redirected, not more's).
> >
> We don't redirect stderr for ${CC}, why we should for ${LINT}?
Bugs in lint. lint outputs most of its diagnostics to stdout, unlike cc.
This is correct since its purpose is to output diagnostics. However, for
some reason it outputs some important diagnostics to stderr.
> I prefer to keep this sort of things out of .mk files, they are
> too shell specific. In the future, we may want to support csh.
Now way. make(1) is specified to use a real shell.
> > > Index: sys/conf/kmod.mk
> > > ===================================================================
> > > RCS file: /home/ncvs/src/sys/conf/kmod.mk,v
> > > retrieving revision 1.114
> > > diff -u -r1.114 kmod.mk
> > > --- sys/conf/kmod.mk 17 Mar 2002 10:05:57 -0000 1.114
> > > +++ sys/conf/kmod.mk 18 Mar 2002 08:49:52 -0000
> > > @@ -339,7 +339,7 @@
> > > regress:
> > >
> > > lint: ${SRCS}
> > > - ${LINT} ${LINTKERNFLAGS} ${CFLAGS:M-[DILU]*} ${.ALLSRC:M*.c} | more 2>&1
> > > + ${LINT} ${LINTKERNFLAGS} ${CFLAGS:M-[DILU]*} ${.ALLSRC:M*.c}
> > >
> > > .include <bsd.dep.mk>
> > >
> > > %%%
> >
> > I changed DILU to DIU here. cc's -L directories are normally just wrong
> > for lint.
> >
> When you say "I changed", do you mean you're not going to commit it for
> some reason? :-)
This means that I have changed it locally so I might commit it eventually :-)
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020320100322.N7832-100000>