Date: Thu, 16 Jun 2011 10:40:36 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Tai-hwa Liang <avatar@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223151 - head/lib/libstand Message-ID: <BANLkTinHid5-55oCYOPEkR5yb_XoyOgTqA@mail.gmail.com> In-Reply-To: <DC08E48D-5A6F-4969-B67A-AB8133B57071@bsdimp.com> References: <201106161535.p5GFZCb7034904@svn.freebsd.org> <DC08E48D-5A6F-4969-B67A-AB8133B57071@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 16, 2011 at 8:53 AM, Warner Losh <imp@bsdimp.com> wrote: > > On Jun 16, 2011, at 9:35 AM, Tai-hwa Liang wrote: > >> Author: avatar >> Date: Thu Jun 16 15:35:12 2011 >> New Revision: 223151 >> URL: http://svn.freebsd.org/changeset/base/223151 >> >> Log: >> Using the correct format string(%zu) for size_t type. This should fix 64 >> bits builds. >> >> Submitted by: Garrett Cooper <yanegomi@gmail.com> > > How about we hold all fixes until it *ACTUALLY* builds on all universe platforms? > > I hate to be cranky, but build breakage costs a lot of time. And for stupid stuff like this? I'm inclined to force WARNS=0 until people can actually fix it right. This was stupid breakage on my part for not running this through universe first. The patch that builds upon this that I submitted in the other thread so far _does_ unbreak universe on ia64 and mips*. Still working on getting it to pass through amd64, i386, and sparc64 at least, which is going to be a few more hours because for some magic reason make -j doesn't work for me with universe. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTinHid5-55oCYOPEkR5yb_XoyOgTqA>