Date: Fri, 17 Nov 2017 10:34:36 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Allan Jude <allanjude@freebsd.org> Subject: Re: svn commit: r316980 - head/contrib/zstd/programs Message-ID: <20171117093436.6wsrynphvcm6re4h@ivaldir.net> In-Reply-To: <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Nov 15, 2017 at 07:38:13PM -0800, Conrad Meyer wrote: > Please revert this change. > > First, it introduces the POLA-violating behavior that zstdcat deletes > its source files. This is not how zcat/bzcat behaves. I have modified zstdcat to behave like zcat/bzcat. The commit you stated is exactly to ensure the zstd(1) command is behaving like xz, gzip, etc (to the exception of zstdcat which was buggy) this commit is needed to have those tools a drop-in replacement for other compression programs. (which is necessary for example to have newsyslog being able to use zstd.) I committed a change needed in base and I will start a discussion with upstream Best regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAloOrSoACgkQY4mL3PG3 PlqzoRAAzQ9gbqSqe4YPbcdjhdKYUN2WpHlPhVkszwkwvn6QwAij+tA72S97A4f1 59OFRHN7DZ7vvphCWKS6BKgAkLKLeRTatz5/22BCZTQkLXSaW99UtvVjF7TBW/sx ko7Sb0QLmqEgoRJwIjANdXB4DR8yq2tgQwmSzZBXlqU4irr+55M0cLZI9K10VWf3 BfWJcHXkQNYmOO1bZv5F33rGhRrb3hillq2UNJgd/VR+ioXWk5pdqD6LPmXpLUtr E2u3sSFEGRuE0EiJS92WVqdBEUmXESl6J76uYY6pX32TOoZzOx9zM8sDYY1CemMn OKjca51DwTe8jA8EsgTToMkDyMqaofehlZau8oCNijlpBZ/BzAOMFlNMExT19feF c9QmH9jdz0N5kEGwh8tcBQ1LNZKBD2kQru8+62yLGspO5ooOYyr8V1czSYRmQ9Td NI7QP3E1bHHg6/DUFhcvRkOfqksJ7y13YGJ9buHkwuy/zfa4eG8iQETj2KI8+JGu cnAnHCY0Uvr6jZJgN/IMSgFWMpFGiFZBbIK8y+WLDl9n97rRKHb6HGIFFEmiJfar qV+L0xzHAUJiT4uHO6ByF9RAakbrzF+LITd5ScS1VUul+M+FPlFaUBxlOuQz7cjf 7bEmFJjUQJbLFl0sSiIcTVCKzXY/c0YOW4str9XN7zrwcRTDZw4= =q0aJ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171117093436.6wsrynphvcm6re4h>