Date: Tue, 10 Feb 2026 00:46:41 +0000 From: Bjoern A. Zeeb <bz@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 840f478eed2a - main - net80211: in net80211_vap_printf() also use vprintf() Message-ID: <698a7ff1.27f6d.4e7bb14d@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=840f478eed2ab18abd1088aa12587bb708a46b56 commit 840f478eed2ab18abd1088aa12587bb708a46b56 Author: Bjoern A. Zeeb <bz@FreeBSD.org> AuthorDate: 2026-01-20 13:43:51 +0000 Commit: Bjoern A. Zeeb <bz@FreeBSD.org> CommitDate: 2026-02-09 21:40:47 +0000 net80211: in net80211_vap_printf() also use vprintf() While everything else uses vprintf() and net80211_vap_printf() vlog() the debug output of wlandebug sessions can be weird. For consistency use vprintf() everywhere to have homogeneous logging. Sponosred by: The FreeBSD Foundation MFC after: 3 days Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D54795 --- sys/net80211/ieee80211_freebsd.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sys/net80211/ieee80211_freebsd.c b/sys/net80211/ieee80211_freebsd.c index b1380eb8a81c..095be79e7bfe 100644 --- a/sys/net80211/ieee80211_freebsd.c +++ b/sys/net80211/ieee80211_freebsd.c @@ -1324,7 +1324,7 @@ net80211_vap_printf(const struct ieee80211vap *vap, const char *fmt, ...) va_start(ap, fmt); snprintf(if_fmt, sizeof(if_fmt), "%s: %s", if_name(vap->iv_ifp), fmt); - vlog(LOG_INFO, if_fmt, ap); + vprintf(if_fmt, ap); va_end(ap); } @@ -1334,14 +1334,12 @@ net80211_vap_printf(const struct ieee80211vap *vap, const char *fmt, ...) void net80211_ic_printf(const struct ieee80211com *ic, const char *fmt, ...) { + char if_fmt[256]; va_list ap; - /* - * TODO: do the vap_printf stuff above, use vlog(LOG_INFO, ...) - */ - printf("%s: ", ic->ic_name); + snprintf(if_fmt, sizeof(if_fmt), "%s: %s", ic->ic_name, fmt); va_start(ap, fmt); - vprintf(fmt, ap); + vprintf(if_fmt, ap); va_end(ap); }home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?698a7ff1.27f6d.4e7bb14d>