Date: Fri, 15 Dec 2006 09:54:58 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: "M. Warner Losh" <imp@bsdimp.com> Cc: perforce@freebsd.org Subject: Re: PERFORCE change 111622 for review Message-ID: <200612150954.58930.hselasky@c2i.net> In-Reply-To: <20061214.222631.-345496069.imp@bsdimp.com> References: <200612131032.kBDAWXcE034886@repoman.freebsd.org> <20061214.222631.-345496069.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 15 December 2006 06:26, M. Warner Losh wrote: > In message: <200612131032.kBDAWXcE034886@repoman.freebsd.org> > > Hans Petter Selasky <hselasky@freebsd.org> writes: > : http://perforce.freebsd.org/chv.cgi?CH=111622 > : > : Change 111622 by hselasky@hselasky_mini_itx on 2006/12/13 10:31:33 > : > : Compile fix: Add missing dependency, vnode_if.h. > : > : Affected files ... > : > : .. //depot/projects/usb/src/sys/modules/ugen/Makefile#2 edit > : > : Differences ... > : > : ==== //depot/projects/usb/src/sys/modules/ugen/Makefile#2 (text+ko) ==== > : > : @@ -3,6 +3,6 @@ > : .PATH: ${.CURDIR}/../../dev/usb > : > : KMOD= ugen > : -SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h > : +SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h vnode_if.h > > What does the usb driver need vnode_if.h for? There was an old > dependency on it, but it was elimianted. > I see that <sys/vnode.h> does no longer include "vnode_if.h". I added this bascially to get the code compiling on some older systems, where "vnode_if.h" is still included by <sys/vnode.h>. I will revert this, and keep the "vnode_if.h" patch in my SVN repo only. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612150954.58930.hselasky>