Date: Mon, 11 Jan 1999 10:12:09 +0100 (MET) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: net@FreeBSD.ORG Subject: HEADS UP: critical dummynet patch Message-ID: <199901110912.KAA19980@labinfo.iet.unipi.it>
next in thread | raw e-mail | index | archive | help
This one is a critical fix for dummynet operation. Please update your
copy of netinet/ip_dummynet.c or at least apply the following patch:
diff -u -r1.3 -r1.4
--- ip_dummynet.c 1998/12/31 07:35:49 1.3
+++ ip_dummynet.c 1999/01/11 11:08:07 1.4
@@ -308,6 +318,7 @@
m_freem(m);
return 0 ; /* XXX error */
}
+ bzero(pkt, sizeof(*pkt) );
/* build and enqueue packet */
pkt->hdr.mh_type = MT_DUMMYNET ;
(struct ip_fw_chain *)pkt->hdr.mh_data = rule ;
cheers
luigi
> From majordom@FreeBSD.ORG Mon Jan 11 10:03:11 1999
> Delivered-To: vmailer-cvs-all@freebsd.org
> From: Luigi Rizzo <luigi@FreeBSD.ORG>
> Date: Mon, 11 Jan 1999 03:08:09 -0800 (PST)
> Message-Id: <199901111108.DAA02953@freefall.freebsd.org>
> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
> Subject: cvs commit: src/sys/netinet ip_dummynet.c
> Sender: owner-cvs-all@FreeBSD.ORG
> Precedence: bulk
>
> luigi 1999/01/11 03:08:09 PST
>
> Modified files:
> sys/netinet ip_dummynet.c
> Log:
> Add a missing bzero which could be the source of instability
> problems reported recently (the rtentry pointer in the dummynet
> queue was not initialized in all cases, resulting in spurious
> rt_refcnt decreases in the lucky cases, and memory trashing in
> other cases.
>
> Revision Changes Path
> 1.4 +21 -12 src/sys/netinet/ip_dummynet.c
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe cvs-all" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901110912.KAA19980>