Date: Sat, 20 Oct 2018 12:59:36 -0700 From: Conrad Meyer <cem@freebsd.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339468 - in head/sys: kern sys Message-ID: <CAG6CVpUdQUYdj2jCmjV_cVmZNm%2B2=%2BapzE0u_xDkND=LTV8Vjw@mail.gmail.com> In-Reply-To: <CABh_MKmTKqCcPbfrA_9HY71GN0heKqSXh-s4ttXemjPK4GCb3Q@mail.gmail.com> References: <201810201831.w9KIVbtN043921@repo.freebsd.org> <CABh_MKmTKqCcPbfrA_9HY71GN0heKqSXh-s4ttXemjPK4GCb3Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ed,
On Sat, Oct 20, 2018 at 11:54 AM Ed Schouten <ed@nuxi.nl> wrote:
> Op za 20 okt. 2018 om 20:31 schreef Conrad Meyer <cem@freebsd.org>:
> > +static int
> > +sbuf_tty_drain(void *a, const char *d, int len)
> > +{
> > + struct tty *tp;
> > + int rc;
> > +
> > + tp = a;
> > +
> > + if (kdb_active) {
> > + cnputsn(d, len);
> > + return (len);
> > + }
> > + if (tp != NULL && panicstr == NULL) {
> > + rc = tty_putstrn(tp, d, len);
> > + if (rc != 0)
> > + return (-ENXIO);
> > + return (len);
> > + }
> > + return (-ENXIO);
> > +}
>
> Disclaimer: Long time since I did a lot with the TTY code.
>
> Can kdb_active, tp == NULL and panicstr != NULL even occur in this
> case? tty_info() can only get called in non-degenerate cases, right?
I think you are correct, but I did not want to investigate to confirm.
This was just the direct, conservative conversion of ttyprintf ->
putchar. The checks can *probably* be removed.
Best regards,
Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUdQUYdj2jCmjV_cVmZNm%2B2=%2BapzE0u_xDkND=LTV8Vjw>