Date: Fri, 14 Jan 2022 09:45:19 +0100 From: Stefan Esser <se@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 82bfeeff10da - main - tools/portconflicts/port_conflicts_check.lua: detect port conflicts Message-ID: <ac3c8cba-536f-6386-5419-e84a562150b7@FreeBSD.org> In-Reply-To: <CACNAnaF%2BpWor8tsih95tdsgWmcpskqz2ajt5==_Y74CsVy3VXw@mail.gmail.com> References: <202201132138.20DLccSU044307@gitrepo.freebsd.org> <CACNAnaF%2BpWor8tsih95tdsgWmcpskqz2ajt5==_Y74CsVy3VXw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------IxwaWpZ4htWGZrWt7WxiwOkG Content-Type: multipart/mixed; boundary="------------zWz9szYrO2z0Wr0dALiYggbm"; protected-headers="v1" From: Stefan Esser <se@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-ID: <ac3c8cba-536f-6386-5419-e84a562150b7@FreeBSD.org> Subject: Re: git: 82bfeeff10da - main - tools/portconflicts/port_conflicts_check.lua: detect port conflicts References: <202201132138.20DLccSU044307@gitrepo.freebsd.org> <CACNAnaF+pWor8tsih95tdsgWmcpskqz2ajt5==_Y74CsVy3VXw@mail.gmail.com> In-Reply-To: <CACNAnaF+pWor8tsih95tdsgWmcpskqz2ajt5==_Y74CsVy3VXw@mail.gmail.com> --------------zWz9szYrO2z0Wr0dALiYggbm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 14.01.22 um 00:13 schrieb Kyle Evans: > and runOn Thu, Jan 13, 2022 at 3:38 PM Stefan E=C3=9Fer <se@freebsd.or= g> wrote: >> >> The branch main has been updated by se: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D82bfeeff10da860b1ed9f03= a01f3282b42b991be >> >> commit 82bfeeff10da860b1ed9f03a01f3282b42b991be >> Author: Stefan E=C3=9Fer <se@FreeBSD.org> >> AuthorDate: 2022-01-13 21:36:09 +0000 >> Commit: Stefan E=C3=9Fer <se@FreeBSD.org> >> CommitDate: 2022-01-13 21:36:09 +0000 >> >> tools/portconflicts/port_conflicts_check.lua: detect port conflict= s >> >> This tool can be used to detect install conflicts (ports/packages = that >> conflict with each other because of identically named files). >> >> MFC after: 3 days >> >=20 > Hi, >=20 > Good to see more use of flua coming into the tree. :-) I recommend > grabbing devel/lua-luacheck and running that over the file -- it's > mostly pointing out complaints about things that should be declared > `local`, but also notes some style-type issues and a write-only > variable. I know about and use luacheck for other projects, did not consider it relevant for such a trivial script, but you are right, I should fix the warnings, especially without global variables (which do not cause any issues, but obviously are style violations). Regards, STefan --------------zWz9szYrO2z0Wr0dALiYggbm-- --------------IxwaWpZ4htWGZrWt7WxiwOkG Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmHhOB8FAwAAAAAACgkQR+u171r99UTQ mAf/ZkIstoCucM0QMZTytxUnYveOjjj+ecedhT/xr4zbCM3yAg45vELOglDMWXtf8L6LpipQciUn 7Ygspxo3fpMT8xGSa7T2VMcl2HgwPzg6ayqtJR244ShSuqCKDQAw6wqZv0FyuDGBfsXCbFjtsxW/ Cq07JLcI+/f+qob3StdznWCs6K5ybtv4EQdHiWGna2q6usGyJ7vv5iQL0G57a9Piaz5h8sVAgTLa gcE/JhK8MblcJizK56xaXRfkTJR7TN2IDSf7MLgz5g4Tb5elCrlXzPExXtzs3sIr6vab2B5ep+Qa XJIpOC5UOZGWLCHhPaeFIYnQmmLZBWMzRikjGg5qPw== =WL0h -----END PGP SIGNATURE----- --------------IxwaWpZ4htWGZrWt7WxiwOkG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ac3c8cba-536f-6386-5419-e84a562150b7>