Date: Mon, 3 Jul 2000 20:50:03 -0700 (PDT) From: David Gilbert <dgilbert@velocet.ca> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/19688: Adding some KASSERTS v1 Message-ID: <200007040350.UAA03392@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/19688; it has been noted by GNATS.
From: David Gilbert <dgilbert@velocet.ca>
To: Bill Fumerola <billf@chimesnet.com>
Cc: David Gilbert <dgilbert@velocet.ca>,
FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/19688: Adding some KASSERTS v1
Date: Mon, 3 Jul 2000 23:41:42 -0400 (EDT)
>>>>> "Bill" == Bill Fumerola <billf@chimesnet.com> writes:
Bill> On Mon, Jul 03, 2000 at 11:15:11PM -0400, David Gilbert wrote:
>> >Description:
>>
>> I'm trying to track down other bugs, so I'm going through
>> networking file-by-file looking for possibly array overflows (which
>> I belive my problem to be). Anyways, I felt that it might be
>> useful if I contributed some of my KASSERT()'s back to the tree.
>> Someone can slap my fingers if this is misguided.
>>
>> >How-To-Repeat:
>>
>> heh.
>>
>> >Fix:
>>
>>
>> --- /sys/net/hostcache.c Fri Aug 27 20:48:15 1999 +++ hostcache.c
>> Mon Jul 3 23:08:34 2000 @@ -55,6 +55,8 @@ struct hchead *heads;
>> u_long nelem;
>>
>> + KASSERT(af >= 0 && af < AF_MAX, ("hc_init: af=%d out of range",
>> af)); + hct = &hctable[af]; nelem = init_nelem; if
>> (hct->hct_nentries)
Bill> [...]
Bill> I can't tell you misguided or not, I can tell you that it's
Bill> misindented though :->
Are we dealing with a tab-stop differenece here? I believe that the
code looks the same when I'm looking at it in my editor.
Dave.
--
============================================================================
|David Gilbert, Velocet Communications. | Two things can only be |
|Mail: dgilbert@velocet.net | equal if and only if they |
|http://www.velocet.net/~dgilbert | are precisely opposite. |
=========================================================GLO================
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007040350.UAA03392>