Date: Wed, 19 Sep 2012 07:31:25 -0500 From: Bryan Drewery <bdrewery@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Chris Rees <crees@freebsd.org>, Thomas Abthorpe <tabthorpe@freebsd.org>, Guido Falsi <madpilot@freebsd.org> Subject: Re: svn commit: r304474 - head/multimedia/cx88 Message-ID: <5059BB1D.60504@FreeBSD.org> In-Reply-To: <20120919093456.GA83232@FreeBSD.org> References: <201209182334.q8INYl5P083094@svn.freebsd.org> <20120919034244.GA29962@FreeBSD.org> <20120919085406.GA10551@micro.madpilot.net> <20120919093456.GA83232@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/19/2012 4:34 AM, Alexey Dokuchaev wrote:
> On Wed, Sep 19, 2012 at 10:54:06AM +0200, Guido Falsi wrote:
>> On Wed, Sep 19, 2012 at 03:42:44AM +0000, Alexey Dokuchaev wrote:
>>> - Created-by: tag is wrongly spelled and should be followed with tab I
>>> think
>>
>> Right. Going to fix this, but not completely sure about the tab rule,
>> anyway it's the same for me, if a tab is preferred I'll add one.
>
> I'm also not sure about the separator; it should be clarified.
Clearly the example in the announcement is a space.
Announcement:
# Created by: J.Q. Public <jqpublic@someaddress.com>
# $FreeBSD$
Example:
# Created By: J.Q. Public
# Created By: J.Q. Public (TAB)
>
>>> - $ finger jah@freebsd.org
>>> [freebsd.org]
>>> Trying 69.147.83.40...
>>> finger: jah: no such user
>>>
>>> - This should have been "Jason Harmening <jason.harmening@gmail.com>"
>>>
>>> - Even for FreeBSD committers, please use their fully qualified identities
>>
>> I intended to just rename the Whom: to Created by: and left the
>> identity as is. If a full identity is requested I'll ask the
>> maintainer if he approves this change(or prefers having just the
>> name or wants to remove the Created by: line).
>
> I think this is bad practice. Nicks are too ambiguous and reserved for
> FreeBSD committers by default (this is not an rule, but rather established
> historical practice). Using "informal" names also creates bad precedent,
> like it's OK to use bogus names like "Anonymous" (when it's not anonymous
> submittion, e.g. with email address; we have some of them already -- looks
> awful) or "4v1l h4c|<3r".
Bad practice or not, if only the creator can have it removed, it only
makes sense only the creator can authorize changing their address.
Especially to some personal email address of theirs.
>
>> BTW there are other ports(not many I admit) with nicknames not
>> present @freebsd.org so I thought it was allowed practice to use
>> nicknames too. What if a contributor expresses preference for
>> inserting just a nickname there?
>
> Personally I think we should require standard full name (with optional
> decorations like III, .Sr, etc.) and politely ask why would one want to
> conceal it. After all, we require it when granting a commit bit. As a last
> resort, there is anonymity option for those who prefer not to reveal their
> full name.
>
Please, let's move on.
> ./danfe
>
--
Regards,
Bryan Drewery
bdrewery@freenode/EFNet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5059BB1D.60504>