Date: Sun, 23 Sep 2007 00:38:04 +0900 From: Norikatsu Shigemura <nork@FreeBSD.org> To: vehemens <vehemens@verizon.net>, jkim@FreeBSD.org Cc: freebsd-bugs@FreeBSD.org Subject: Re: kern/114688: [drm] RADEON/AIGLX/DRM Problem Message-ID: <20070923003804.fd9a08ff.nork@FreeBSD.org> In-Reply-To: <200709210200.l8L20F9l067670@freefall.freebsd.org> References: <200709210200.l8L20F9l067670@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi vehemens! On Fri, 21 Sep 2007 02:00:15 GMT vehemens <vehemens@verizon.net> wrote: > Revised 7-current patch with Jung-uk Kim's style fixes. I didn't know this PR. I was embarrassed about this issue, too. I confirmed that following patch is GOOD works. >> jkim Would you please commit your patch? > --- drm_drv.c.orig 2006-09-07 16:04:47.000000000 -0700 > +++ drm_drv.c 2007-09-20 12:20:24.000000000 -0700 > @@ -711,6 +711,9 @@ > return EINVAL; > } > > + if (--priv->refs != 0) > + goto done; > + > if (dev->driver.preclose != NULL) > dev->driver.preclose(dev, filp); > > @@ -786,17 +789,17 @@ > dev->buf_pgid = 0; > #endif /* __NetBSD__ || __OpenBSD__ */ > > - if (--priv->refs == 0) { > - if (dev->driver.postclose != NULL) > - dev->driver.postclose(dev, priv); > - TAILQ_REMOVE(&dev->files, priv, link); > - free(priv, M_DRM); > - } > + > + if (dev->driver.postclose != NULL) > + dev->driver.postclose(dev, priv); > + TAILQ_REMOVE(&dev->files, priv, link); > + free(priv, M_DRM); > > /* ======================================================== > * End inline drm_release > */ > > +done: > atomic_inc( &dev->counts[_DRM_STAT_CLOSES] ); > #ifdef __FreeBSD__ > device_unbusy(dev->device);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070923003804.fd9a08ff.nork>