Date: Wed, 3 Dec 2014 00:46:32 -0700 From: Warner Losh <imp@bsdimp.com> To: Alfred Perlstein <alfred@freebsd.org> Cc: freebsd-arch@freebsd.org Subject: Re: enable TRIM by default ? Message-ID: <9C982798-2DD9-407C-9231-2C5F2926301D@bsdimp.com> In-Reply-To: <547EB991.8000303@freebsd.org> References: <89094.1417506193@critter.freebsd.dk> <20141203071447.GC13944@server.rulingia.com> <547EB991.8000303@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Dec 3, 2014, at 12:19 AM, Alfred Perlstein <alfred@freebsd.org> wrote: > > > On 12/2/14 11:14 PM, Peter Jeremy wrote: >> On 2014-Dec-02 07:43:13 +0000, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: >>> Isn't it time that we enable TRIM by default in newfs ? >> As an alternative viewpoint, I have a SSD that got severe indigestion when >> I tried to enable TRIM: >> aspire kernel: ad0: TIMEOUT - CFA ERASE retrying (1 retry left) >> aspire kernel: ad0: WARNING - SETFEATURES SET TRANSFER MODE taskqueue timeout - completing request directly >> aspire kernel: ata1: error issuing SETFEATURES ENABLE WCACHE command >> aspire kernel: ata1: error issuing SET_MULTI command >> aspire kernel: ata1: error issuing WRITE_DMA command >> The kernel then went to 1 core of interrupt and wedged. >> >> I admit that it's about 3 years old but smartctl says it's still got lots of >> life left in it and googling suggests they are still available. >> >> The problem is that if a SSD doesn't support TRIM, it is likely to have all >> sorts of misbehaviour if you attempt to enable TRIM. If TRIM is enabled by >> default, you need to provide a simple way to disable it if the system can't >> cope. >> > Is there a hints/quirks system we can use? > > So: default to on, quirks/hints sets to off? IMO, CFA ERASE is a big clue something is amiss for anything that isn’t a bona-fide CF card. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUfr/YAAoJEGwc0Sh9sBEAVT4QAJelSRPPb2c/g+Dds1rP0ht0 GcyHH3DgfRWawFsFoBy1iEW4MwIh0DbwLoIT5Xubzxfby7/KYB0nIbRH9Vxzba8m FxLo30thUqN1KaG1oiZHXjwebZoycaOJPnm198xAVs/5MXh8dqi8HwoRqv64oiy2 QdQ6Xk+n7BblE45M1DogLGnIM2o5QyrA1O9zyegXRrCDIey993O3OKEELnx1KO+k 6wUPf3FmiPFAI3gnQjw+EJfSkGzf9GFtDmPIhJ7LuS1Fo5p8AAD8HUSjRDGemI6P 5T/ZQqP4YgQIVis63bwdc8SalO3PHEEFowSw8vRyCBeC0oKzu4Uqly3ZqJlYlxRx dmXzK6SYuFwVWY9/wIw4p5wRjs4kfVQVZUchwF2pIOGSqoKooeB6a0JkSm0meedy w83L2C5BnPrmVf2mMGm/LySYUsveHO/drgqeYO/y9T6tTw0WSH5jISZmejH0kGcW 522U6UHtHCit4Id8V2q6TckoHeLflB+sHxf3ZduAvEWkcjrj5PPs0fjTsmU9G3iy zLvnkzHWZH+ANiE34h/cPZRzxG4hKj/2ytDtMKNqiabXeM2sIIfJfMyHFaiSIuC6 PVQtOzWJq5hR+/MocV8f2hvjij2GkILNwazXgO8Y65Sl0eAVYg9D0zjKGGOMkLOQ jQ+khk3hLX+IzqLaDWx0 =VtVY -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9C982798-2DD9-407C-9231-2C5F2926301D>