Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 May 2021 15:25:55 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: db3ccc52a6a3 - stable/12 - libpfct: Fix PIC flag
Message-ID:  <202105071525.147FPtHA026713@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=db3ccc52a6a3204291d5e69b037004fb29149015

commit db3ccc52a6a3204291d5e69b037004fb29149015
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-04-16 19:00:51 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-05-07 08:16:03 +0000

    libpfct: Fix PIC flag
    
    Use ${PICFLAG} rather than hard-adding -fPIC, which removes the
    requirement for libnv to be built PIC.
    
    MFC after:      4 weeks
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit 8403170b3d39326f836bc999534fe8c4d41cda11)
---
 lib/libnv/Makefile    | 1 -
 lib/libpfctl/Makefile | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/libnv/Makefile b/lib/libnv/Makefile
index 2e227cbc0b04..bf92041d4c87 100644
--- a/lib/libnv/Makefile
+++ b/lib/libnv/Makefile
@@ -10,7 +10,6 @@ SHLIB_MAJOR= 0
 
 .PATH: ${SRCTOP}/sys/contrib/libnv ${SRCTOP}/sys/sys
 CFLAGS+=-I${.CURDIR}
-CFLAGS+=${PICFLAG}
 
 SRCS=	cnvlist.c
 SRCS+=	dnvlist.c
diff --git a/lib/libpfctl/Makefile b/lib/libpfctl/Makefile
index d7a00a94b349..69500ae496f4 100644
--- a/lib/libpfctl/Makefile
+++ b/lib/libpfctl/Makefile
@@ -7,6 +7,6 @@ INTERNALLIB=	true
 SRCS=	libpfctl.c
 INCS=	libpfctl.h
 
-CFLAGS+=	-fPIC
+CFLAGS+=${PICFLAG}
 
 .include <bsd.lib.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105071525.147FPtHA026713>