Date: Mon, 16 Nov 1998 13:47:05 -0500 (EST) From: cnh@mindspring.net To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: ports/8712: fix for SKIP breakage in -STABLE Message-ID: <199811161847.NAA29470@foo.eng.mindspring.net>
next in thread | raw e-mail | index | archive | help
>Number: 8712
>Category: ports
>Synopsis: fix for SKIP breakage in -STABLE
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 16 10:50:01 PST 1998
>Last-Modified:
>Originator: Christopher N. Harrell
>Organization:
Mindspring Enterprises
>Release: FreeBSD 2.2.7-STABLE i386
>Environment:
2.2.7-STABLE w/ no modifications
>Description:
SKIP does not handle large (>mtu) packets properly.
>How-To-Repeat:
Install SKIP on two hosts, ping -s 1500 one from the other.
>Fix:
[cnh@bar /usr/ports/security/skip/work/skip/freebsd]% for i in *.orig; do echo ${i%%.orig}; diff $i ${i%%.orig}; done
skip_es.c
1769c1769
< m->m_flags &= ~ M_EOR;
---
> m->m_flags &= ~ M_PROTO1;
2233c2233
< outbuf->m_flags |= M_EOR | M_PKTHDR;
---
> outbuf->m_flags |= M_PROTO1 | M_PKTHDR;
skip_if.h
107c107
< #define SKIP_DECRYPTED(m) ((m)->m_flags & M_EOR)
---
> #define SKIP_DECRYPTED(m) ((m)->m_flags & M_PROTO1)
I believe that skip's use of M_EOR was being misinterpreted by something else.
It *looks* like M_PROTO1 is a protocol specific flag and can be used safely in
this way, but this could very well break something else; Use with caution.
cheers,
Christopher
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199811161847.NAA29470>