Date: Thu, 3 Apr 2025 17:38:46 +0000 From: Colin Percival <cperciva@tarsnap.com> To: Tom Jones <thj@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 74a6f2a76b32 - main - iwx: Shorten log code field Message-ID: <01000195fcbbe2ea-17ef9c04-6d3f-4df7-b18b-c52b72dc4565-000000@email.amazonses.com> In-Reply-To: <202504030707.53377PCW040790@gitrepo.freebsd.org> References: <202504030707.53377PCW040790@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/3/25 00:07, Tom Jones wrote:
> commit 74a6f2a76b32e01d05c4ad71897bd3a6831e703e
>
> This fixes the build on i386.
You sure about that?
/usr/src/sys/dev/iwx/if_iwx.c:5762:22: error: shift count >= width of type
[-Werror,-Wshift-count-overflow]
5762 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
le32toh(desc->tbs[0].tb_len)) >> 32)
| ^ ~~
/usr/src/sys/dev/iwx/if_iwx.c:5762:80: error: shift count >= width of type
[-Werror,-Wshift-count-overflow]
5762 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
le32toh(desc->tbs[0].tb_len)) >> 32)
|
^ ~~
/usr/src/sys/dev/iwx/if_iwx.c:5769:22: error: shift count >= width of type
[-Werror,-Wshift-count-overflow]
5769 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
le32toh(desc->tbs[1].tb_len)) >> 32)
| ^ ~~
/usr/src/sys/dev/iwx/if_iwx.c:5769:80: error: shift count >= width of type
[-Werror,-Wshift-count-overflow]
5769 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
le32toh(desc->tbs[1].tb_len)) >> 32)
|
^ ~~
/usr/src/sys/dev/iwx/if_iwx.c:5778:23: error: shift count >= width of type
[-Werror,-Wshift-count-overflow]
5778 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
le32toh(desc->tbs[i + 2].tb_len)) >> 32)
| ^ ~~
/usr/src/sys/dev/iwx/if_iwx.c:5778:85: error: shift count >= width of type
[-Werror,-Wshift-count-overflow]
5778 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
le32toh(desc->tbs[i + 2].tb_len)) >> 32)
|
^ ~~
/usr/src/sys/dev/iwx/if_iwx.c:10971:47: error: format specifies type 'unsigned
long' but the argument has type 'uint64_t' (aka 'unsigned long long')
[-Werror,-Wformat]
10971 | DPRINTF(("%s: k->wk_keytsc=%lu\n", __func__, k->wk_keytsc));
| ~~~ ^~~~~~~~~~~~
| %llu
--
Colin Percival
FreeBSD Release Engineering Lead & EC2 platform maintainer
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01000195fcbbe2ea-17ef9c04-6d3f-4df7-b18b-c52b72dc4565-000000>