Date: Tue, 22 Sep 2020 22:01:40 -0500 From: Kyle Evans <kevans@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, Ian Lepore <ian@freebsd.org>, Mateusz Guzik <mjguzik@gmail.com>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r365643 - head/bin/cp Message-ID: <CACNAnaFtpHBCW4G46Lfx55F-%2B=Diij1q6nOd0BA9q4jV4aqK2g@mail.gmail.com> In-Reply-To: <CAOtMX2hLXbWE2ZMbswC96KmB7rWAwa%2BmSAJnHNptH7DqkE8RXA@mail.gmail.com> References: <202009112049.08BKnavL032212@repo.freebsd.org> <CACNAnaGXCt=PezNX-5KU7xTk%2By-um37p8sk1c1KUEc4ywDQ5uQ@mail.gmail.com> <CAOtMX2gtCmyRrhUVia6Arc_PCbgoasG61Xwt=cUaDd1Q1Gtw8g@mail.gmail.com> <CAGudoHEoF3T=hD7-tSNzz0--xKB3LwbjZQH1Xtxujq19hdm2vg@mail.gmail.com> <CAOtMX2i9v73ydzCNz-ZWEZvTot68%2BoT7c0UBE4soOMOcRjBiyA@mail.gmail.com> <CACNAnaGO2FJeKOPXJZ3-etyQf03hvk-kuqj75hKCpg3JQD54=g@mail.gmail.com> <CAOtMX2geGiny1rDMKE7v94R33gb0NcpcJ9k%2B3TrHzsdc5DC8hQ@mail.gmail.com> <CACNAnaGDULoCpp7Rh%2B9mSfC-=uSXiHWOPh9_STpy2yA%2BtSk85A@mail.gmail.com> <CAOtMX2iPqRh6P3JSX3V0erEAzaeN1g4jCAyhTz5O3__ffsBtkA@mail.gmail.com> <CANCZdfqx%2BOboQFZ4xzCeOdNahPkNP3X8yeMD6uVSwHvv2=cinA@mail.gmail.com> <CACNAnaH-L%2Bw=SJW1Cw1M63LQi19d%2Bf_8Sv%2BdYUTyE%2BjYQU6nbA@mail.gmail.com> <CANCZdfrfOrFAkcRWbhQSW9qgyJ6JFyMrgMqrN=YS7eKoT1FmEA@mail.gmail.com> <CAOtMX2iNhii4tCwvTSn7JGNAJ_afoyjwQYM=8MUo4fitt992Kg@mail.gmail.com> <CANCZdfqs8Hrmm-mHConJCW29PRHAPByTwP8J0aTR6naxNL7Ncg@mail.gmail.com> <fa3840e0a94d239c3ca42bdb7f16f033b90fbd98.camel@freebsd.org> <CACNAnaF5XdL2vF%2BofHPXzEu=Pi9=pTaGLnv9evryfvV6y=sBSA@mail.gmail.com> <CANCZdfoeRQr3S803-Gcb_jF%2B=ALs1mO1ezjMQdks2_%2BN8onXHA@mail.gmail.com> <CACNAnaFtcz93XXnq=zssK0K2V94dCLDzThpqxrjhYGLzM5qADg@mail.gmail.com> <CANCZdfp=omyH7FxLaKmL-=rg=8evEvNnPj459sigbEy_xXtaRw@mail.gmail.com> <CAOtMX2hLXbWE2ZMbswC96KmB7rWAwa%2BmSAJnHNptH7DqkE8RXA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Correct- we're good now. Thanks! On Tue, Sep 22, 2020 at 9:59 PM Alan Somers <asomers@freebsd.org> wrote: > > Go ahead and commit. Consider it reviewed by me. And if I understand co= rrectly, this commit means there's no need for a special updating procedure= , right? > > On Tue, Sep 22, 2020 at 6:55 PM Warner Losh <imp@bsdimp.com> wrote: >> >> >> >> On Tue, Sep 22, 2020 at 5:17 PM Kyle Evans <kevans@freebsd.org> wrote: >>> >>> On Tue, Sep 22, 2020, 17:02 Warner Losh <imp@bsdimp.com> wrote: >>>> >>>> >>>> >>>> On Tue, Sep 22, 2020 at 3:55 PM Kyle Evans <kevans@freebsd.org> wrote: >>>>> >>>>> On Tue, Sep 22, 2020 at 4:53 PM Ian Lepore <ian@freebsd.org> wrote: >>>>> > >>>>> > On Tue, 2020-09-22 at 15:50 -0600, Warner Losh wrote: >>>>> > > I think it's a great leap sideways, but I've done cp /dev/null fo= o to >>>>> > > clear >>>>> > > it out for 35 years now... It's why it feels like a workaround. >>>>> > > >>>>> > > Though it is a legit optimization, no matter the feelings. As for >>>>> > > clearer, >>>>> > > I'm less sure since then I have to remember what the : operator d= oes. >>>>> > > >>>>> > > Warner >>>>> > > >>>>> > >>>>> > For me, :> is idiomatic (but ugly). >>>>> > >>>>> > On the other hand, the cp /dev/null had a nice dogfooding aspect to >>>>> > it... when we broke cp by accident, its use in the build system was= the >>>>> > first alarm to go off. >>>>> > >>>>> > --Ian >>>>> > >>>>> >>>>> To be honest, this is a case that really should be covered by >>>>> regression tests somewhere. >>>> >>>> >>>> It should (but isn't yet). >>>> >>>> Ian is right for old-school FreeBSD thinking. In that thinking the bui= ld system should use an eclectic mix of tools to act as a fire-wall against= accidental breakage. >>>> >>>> Complete, effective, test suites give much better coverage... if they = are run... >>>> >>>> So until we run tests frequently, with loud regression squawking that'= s as effective as build breakage, I tend to fall in the 'all of the above' = camp until that's in place... :) >>>> >>>> Warner >>>> >>>> P.S. though not, if I suppose, if it means that we're slowing down the= regression coverage uptake... >>> >>> >>> -- >>> >>> The test build was fine, please confirm if I can commit it or if someon= e else would like to write the UPDATING notice or start bootstrapping cp on= systems that were affected. I'm not comfortable with not taking any path a= t all here, but this is a lot of friction for a small mechanical change to = ease the pain. >> >> >> Sorry if I wasn't clear: I'm not objecting to the quick mechanical chang= e so much as complaining that I wish we had better test coverage. Don't let= that stop you from doing what's right (or I can if you'd like). >> >> Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFtpHBCW4G46Lfx55F-%2B=Diij1q6nOd0BA9q4jV4aqK2g>