Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Aug 2016 20:50:56 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 211965] [patch] fmodl not properly aliased on architectures where LDBL_PREC == 53 (arm, mips, powerpc)
Message-ID:  <bug-211965-8-3V5arIHAiT@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-211965-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-211965-8@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211965

Kyle Evans <bsdports@kyle-evans.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173822|0                           |1
        is obsolete|                            |

--- Comment #1 from Kyle Evans <bsdports@kyle-evans.net> ---
Created attachment 174233
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=174233&action=edit
svn(1) diff of lib/msun/src, standardizing conditionals and properly aliasing
fmodl

As mentioned by Warner Losh [1], LDBL_MANT_DIG == 53 could be written as
LDBL_MANT_DIG == DBL_MANT_DIG to better convey the intention of this block.

I've amended this to do that, as well as to give the same treatment to the
other instances where the same meaning is intended. Also, I've standardized all
of these to a form without parentheses enclosing the statement.

This could presumably be split out into a patch solely addressing the aliasing
of fmodl and a patch addressing the consistency nits, but this is trivial
enough that I left it alone.

[1] https://lists.freebsd.org/pipermail/freebsd-arm/2016-August/014604.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211965-8-3V5arIHAiT>