Date: Wed, 2 Nov 2016 09:11:56 +0000 From: Antoine Brodin <antoine@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Ed Maste <emaste@freebsd.org>, Jonathan Anderson <jonathan@freebsd.org> Subject: Re: svn commit: r308181 - in head: . share/mk Message-ID: <CAALwa8=iq7amLZ_eSrqsynzAkmg43vAFFbd5pvyr=LFtFd1ifw@mail.gmail.com> In-Reply-To: <459BD98A-4788-497E-B2D5-5EC20C5B9EE8@FreeBSD.org> References: <201611012127.uA1LRg0B045900@repo.freebsd.org> <46715A69-03C5-404F-B133-C8FE89D59A9B@FreeBSD.org> <69A64340-FE51-4AF0-9905-B46220D041E9@FreeBSD.org> <459BD98A-4788-497E-B2D5-5EC20C5B9EE8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 2, 2016 at 7:53 AM, Dimitry Andric <dim@freebsd.org> wrote:
> On 02 Nov 2016, at 08:25, Jonathan Anderson <jonathan@FreeBSD.org> wrote:
>>
>> On 1 Nov 2016, at 21:10, Dimitry Andric wrote:
>>
>>> Please note, I reverted r307823 (which changed the suffixes from .bco
>>> and .llo to .bc and .ll) in r308003, since it caused a number of ports
>>> failures. These ports were already using .ll as a suffix for C++ lex
>>> scripts.
>>
>> The changes to bsd.suffixes-posix.mk (included by sys.mk) would have aff=
ected anything compiled with bmake, and indeed, I'd imagine that adding a .=
c->.ll rule alongside .c->.o could cause problems with C++ lex rules. In fa=
ct, part of brooks' original motivation for introducing .llo suffixes was t=
o avoid name conflicts (although conflicts with program IR like we're intro=
ducing in this commit). The changes in this commit should only be picked up=
by things that explicit include bsd.{lib,prog}.mk, however, and they also =
have slightly more esoteric names (e.g., progname.full.ll) that are less li=
kely to cause a conflict. Perhaps I ought to have done an exp-run, but I su=
spect that this commit will cause much less / no fallout. I don't suppose y=
ou have a list of the ports that failed after your r307823 change so that I=
could do spot checks?
>
> Hi Antoine, you pointed me at some of these port failures due to the .ll
> change, do you still have a list of them?
The failures were:
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/super-smack-1.3_2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/dprog-0.3.1_2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/ebnf2yacc-0.1.1.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/gnuchess-6.2.3.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/bugle-0.0.20100508_2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/hfst-3.8.2.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/grap-1.45.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/g-cows-1.12.log
http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p424659_s307=
951/logs/worker-3.8.4.log
Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=iq7amLZ_eSrqsynzAkmg43vAFFbd5pvyr=LFtFd1ifw>